Skip to content

/ font-kit

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix DirectWrite typographic bounds calculation #91

Closed
wants to merge 1 commit into from
Closed

Fix DirectWrite typographic bounds calculation #91

wants to merge 1 commit into from

Conversation

@idursun
Copy link
Contributor

idursun commented Jul 25, 2019 •
edited

Fixes #85

  • Reverted back to raster_bounds calculation to use Loader::raster_bounds calculation. This aligns raster_bounds with the rest of the loaders.
  • Fixed miscalculation of width and height in the DirectWrite::typographic_bounds. Bearings were being subtracted instead of being added.
$ cargo run --example render-glyph ArialMT { 32
glyph 94:

            ▓▓██████
          ██████████
        ▒▒████▒▒
        ▓▓██▓▓
        ▓▓██▓▓
        ▓▓██▓▓
        ▓▓██▓▓
        ▓▓██▓▓
        ▓▓██▓▓
        ████▓▓
        ████▒▒
      ▒▒████▒▒
    ▒▒████▓▓
░░████████
░░████▒▒
░░████████
    ▒▒████▓▓
      ▒▒████▒▒
      ░░████▒▒
        ████▓▓
        ▓▓██▓▓
        ▓▓██▓▓
        ▓▓██▓▓
        ▓▓██▓▓
        ▓▓██▓▓
        ▓▓██▓▓
        ▒▒████▒▒
          ██████████
            ▓▓██████
@idursun
Fix dwrite typographic bounds calculation
Verified
This commit was signed with a verified signature.
idursun ibrahim dursun
GPG key ID: E6C6E5931E4926BF Learn about signing commits
Loading status checks…
971fb07
@idursun idursun changed the title Fix DriectWrite typographic bounds calculation Fix DirectWrite typographic bounds calculation Jul 25, 2019
@idursun
Copy link
Contributor Author

idursun commented Jul 25, 2019

Test failed. Working on it.
@idursun idursun closed this Jul 25, 2019
@idursun idursun deleted the idursun:fix-dwrite-typographic-bounds branch Jul 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

Clipped rendering on Windows
1 participant
@idursun
You can’t perform that action at this time.