Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MP3, Ogg/Vorbis and Flac playback #54

Merged
merged 5 commits into from Nov 8, 2017

Conversation

@philn
Copy link
Collaborator

commented Nov 7, 2017

In this PR the MP3 decoder and demuxer are imported from Gecko. I validated by locally modifying the wav playback test with an mp3 file.
Same for Ogg/Vorbis and Flac support.

@philn philn requested a review from cpearce Nov 7, 2017

@philn

This comment has been minimized.

Copy link
Collaborator Author

commented Nov 7, 2017

bors-servo added a commit that referenced this pull request Nov 7, 2017

Auto merge of #54 - servo:mp3-playback, r=<try>
MP3 playback

In this PR the MP3 decoder and demuxer are imported from Gecko. I validated by locally modifying the wav playback test with an mp3 file.
@bors-servo

This comment has been minimized.

Copy link
Collaborator

commented Nov 7, 2017

⌛️ Trying commit 3ed7a79 with merge d40ca11...

@philn philn changed the title MP3 playback MP3 and Ogg/Vorbis playback Nov 7, 2017

@philn philn changed the title MP3 and Ogg/Vorbis playback MP3, Ogg/Vorbis and Flac playback Nov 7, 2017

philn added some commits Nov 7, 2017

Ogg/Vorbis playback support
Ogg/Flac might also work but it's untested.

@philn philn force-pushed the mp3-playback branch from c34e21b to 520c282 Nov 7, 2017

@cpearce

cpearce approved these changes Nov 7, 2017

@cpearce

This comment has been minimized.

Copy link
Contributor

commented Nov 7, 2017

We should have tests, like what we have for the WAV support, that tests that we can play these formats. They should not be in a separate player app, they should be in our test suite here.

@cpearce

This comment has been minimized.

Copy link
Contributor

commented Nov 7, 2017

@bors-servo r=cpearce

@bors-servo

This comment has been minimized.

Copy link
Collaborator

commented Nov 7, 2017

📌 Commit 520c282 has been approved by cpearce

@bors-servo

This comment has been minimized.

Copy link
Collaborator

commented Nov 7, 2017

⌛️ Testing commit 520c282 with merge f861c36...

bors-servo added a commit that referenced this pull request Nov 7, 2017

Auto merge of #54 - servo:mp3-playback, r=cpearce
MP3, Ogg/Vorbis and Flac playback

In this PR the MP3 decoder and demuxer are imported from Gecko. I validated by locally modifying the wav playback test with an mp3 file.
Same for Ogg/Vorbis and Flac support.
@bors-servo

This comment has been minimized.

Copy link
Collaborator

commented Nov 8, 2017

☀️ Test successful - status-travis
Approved by: cpearce
Pushing f861c36 to master...

@bors-servo bors-servo merged commit 520c282 into master Nov 8, 2017

3 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
homu Test successful
Details

@philn philn deleted the mp3-playback branch Nov 8, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.