Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for the client storage extension #126

Merged
merged 3 commits into from Nov 7, 2017

Conversation

@jrmuizel
Copy link
Contributor

jrmuizel commented Oct 13, 2017

This change is Reviewable

@jrmuizel jrmuizel force-pushed the jrmuizel:client-storage branch from 9c0923d to 98d702a Oct 14, 2017
@jrmuizel
Copy link
Contributor Author

jrmuizel commented Oct 16, 2017

I've filed brendanzab/gl-rs#429 about adding a private field to the generated structs. We might as well try to do that first so we only need to bump the major version now and not next time.

@bors-servo
Copy link
Contributor

bors-servo commented Oct 19, 2017

The latest upstream changes (presumably #128) made this pull request unmergeable. Please resolve the merge conflicts.

@kvark
Copy link
Member

kvark commented Oct 19, 2017

Thanks! Could you rebase and squash please?
I think we'll still need to wrap up those ffi calls (to client storage and such) in rusty functions, but that would be non-breaking follow-ups.

@jrmuizel
Copy link
Contributor Author

jrmuizel commented Oct 19, 2017

I'd like some more progress on brendanzab/gl-rs#429 before I try rebasing this.

@jrmuizel jrmuizel force-pushed the jrmuizel:client-storage branch from 98d702a to 400d0ea Nov 5, 2017
@jrmuizel
Copy link
Contributor Author

jrmuizel commented Nov 5, 2017

I've dropped the version change commit now that gl_generator has been updated to include a private field.

@kvark
Copy link
Member

kvark commented Nov 6, 2017

@jrmuizel let's switch gl_generator dependency to 0.6.1 and bump the minor version (of gleam) here?

@jrmuizel
Copy link
Contributor Author

jrmuizel commented Nov 6, 2017

Done

@kvark
Copy link
Member

kvark commented Nov 6, 2017

Thanks! Squash it, please?

@jrmuizel
Copy link
Contributor Author

jrmuizel commented Nov 7, 2017

Why? Aren't they separate things?

@kvark
Copy link
Member

kvark commented Nov 7, 2017

It seems weird to have a multiple micro commits (one liners) following each other. Just because they can be treated independently doesn't mean they should? Anyhow, I don't have strong feelings about this.

@jrmuizel jrmuizel merged commit 8a4f08b into servo:master Nov 7, 2017
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.