Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upAdd support for the client storage extension #126
Conversation
|
I've filed brendanzab/gl-rs#429 about adding a private field to the generated structs. We might as well try to do that first so we only need to bump the major version now and not next time. |
|
|
|
Thanks! Could you rebase and squash please? |
|
I'd like some more progress on brendanzab/gl-rs#429 before I try rebasing this. |
|
I've dropped the version change commit now that gl_generator has been updated to include a private field. |
|
@jrmuizel let's switch |
|
Done |
|
Thanks! Squash it, please? |
|
Why? Aren't they separate things? |
|
It seems weird to have a multiple micro commits (one liners) following each other. Just because they can be treated independently doesn't mean they should? Anyhow, I don't have strong feelings about this. |
jrmuizel commentedOct 13, 2017
•
edited by larsbergstrom
This change is