Add program binary related functions #132
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kvark
requested changes
Nov 7, 2017
src/gl_fns.rs
Outdated
| if len <= 0 { | ||
| return Vec::new(); | ||
| } | ||
| let mut binary: Vec<u8> = Vec::new(); |
There was a problem hiding this comment.
nit: could be Vec::with_capacity(len as _)
src/gl_fns.rs
Outdated
| @@ -1149,6 +1149,53 @@ impl Gl for GlFns { | |||
| } | |||
| } | |||
|
|
|||
| fn get_program_binary(&self, program: GLuint, format: &mut GLenum) -> Vec<u8> { | |||
There was a problem hiding this comment.
format should be part of the returned value, not input parameter
src/gles_fns.rs
Outdated
| @@ -1121,6 +1121,41 @@ impl Gl for GlesFns { | |||
| } | |||
| } | |||
|
|
|||
| fn get_program_binary(&self, program: GLuint, format: &mut GLenum) -> Vec<u8> { | |||
There was a problem hiding this comment.
out of scope here, but it's unfortunate that we duplicate as much code as we do between GL/GLES
|
Change has a wrong change, I am going to update it. |
|
@kvark, can you review the change again? |
kvark
approved these changes
Nov 8, 2017
|
Thank you! |
|
📌 Commit 2cecc19 has been approved by |
bors-servo
pushed a commit
that referenced
this pull request
Nov 8, 2017
Add program binary related functions Add program binary related functions. They are going to be used to speed up webrender shaders initializations. This pull request is related to [Bug 1391159](https://bugzilla.mozilla.org/show_bug.cgi?id=1391159) <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/gleam/132) <!-- Reviewable:end -->
|
☀️ Test successful - status-travis |
|
Can we have this to be published as a new version on crates.io? Thanks! |
|
@sotaroikeda Published 0.4.13 on crate.io. |
|
Thanks a lot! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add program binary related functions. They are going to be used to speed up webrender shaders initializations.
This pull request is related to Bug 1391159
This change is