New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Work around incorrect getShaderPrecisionFormat implementations. #175

Merged
merged 2 commits into from Nov 2, 2018

Conversation

Projects
None yet
3 participants
@jdm
Member

jdm commented Nov 1, 2018

@kvark

kvark approved these changes Nov 2, 2018

@kvark

This comment has been minimized.

Member

kvark commented Nov 2, 2018

@bors-servo

This comment has been minimized.

Contributor

bors-servo commented Nov 2, 2018

📌 Commit e4ca541 has been approved by kvark

@bors-servo

This comment has been minimized.

Contributor

bors-servo commented Nov 2, 2018

⌛️ Testing commit e4ca541 with merge 561627e...

bors-servo added a commit that referenced this pull request Nov 2, 2018

Auto merge of #175 - servo:precision, r=kvark
Work around incorrect getShaderPrecisionFormat implementations.

This is following https://chromium.googlesource.com/chromium/src/gpu/+/master/command_buffer/service/gl_utils.cc#155 in order to fix servo/servo#22082.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/gleam/175)
<!-- Reviewable:end -->
@bors-servo

This comment has been minimized.

Contributor

bors-servo commented Nov 2, 2018

☀️ Test successful - status-travis
Approved by: kvark
Pushing 561627e to master...

@bors-servo bors-servo merged commit e4ca541 into master Nov 2, 2018

3 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
homu Test successful
Details

@kvark kvark deleted the precision branch Nov 2, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment