Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upFix build on unix-like systems that are not linux #91
Conversation
|
Also added pkg-config because of the Travis says Anyway, Webrender on FreeBSD! |
|
I've tried restarting the travis build. |
|
This looks good to me, can you bump the version number too? Thanks! And that screenshot is awesome! :) |
|
Bumped. |
|
@bors-servo r=emilio |
|
|
|
|
bors-servo
added a commit
that referenced
this pull request
Oct 22, 2016
Fix build on unix-like systems that are not linux Assuming that everything other than linux or windows uses darwin-style frameworks is... strange ;-) gleam builds fine on FreeBSD after this change. (update: [got the whole Webrender working](https://unrelenting.technology/notes/2016-10-21-21-16-04)!) <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/gleam/91) <!-- Reviewable:end -->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
myfreeweb commentedOct 21, 2016
•
edited
Assuming that everything other than linux or windows uses darwin-style frameworks is... strange ;-)
gleam builds fine on FreeBSD after this change. (update: got the whole Webrender working!)
This change is