Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cap number of files that are listed in "heads up" comment #175

Closed
jdm opened this issue Apr 12, 2017 · 5 comments · Fixed by #176
Closed

Cap number of files that are listed in "heads up" comment #175

jdm opened this issue Apr 12, 2017 · 5 comments · Fixed by #176
Labels
E-Easy

Comments

@jdm
Copy link
Member

jdm commented Apr 12, 2017

We should list the first five files, followed by "and N more".
@jdm jdm added the E-Easy label Apr 12, 2017
@highfive
Copy link
Collaborator

Hi! If you have any questions regarding this issue, feel free to make a comment here, or ask it in the #servo channel in IRC.

If you intend to work on this issue, then add @highfive: assign me to your comment, and I'll assign this to you. 😄

@jdm
Copy link
Member Author

jdm commented Apr 12, 2017

Code: https://github.com/servo/highfive/blob/master/handlers/watchers/__init__.py

@pyfisch
Copy link
Contributor

pyfisch commented Apr 14, 2017

@highfive: assign me

@pyfisch
Copy link
Contributor

pyfisch commented Apr 14, 2017

Huhu?

@highfive: assign me

@jdm
Copy link
Member Author

jdm commented Apr 14, 2017

This repository doesn't have the "C-assigned" label present.

@pyfisch pyfisch mentioned this issue Apr 14, 2017
Merged
bors-servo pushed a commit that referenced this issue Apr 14, 2017
Auto merge of #176 - pyfisch:issue175, r=jdm
c96df49 
Cap number of files that are listed in "heads up" comment

Only the first five files are shown.
"and n more" tells how many files were omitted.

closes #175
Mark-Simulacrum pushed a commit to Mark-Simulacrum/highfive that referenced this issue Sep 8, 2020
@nrc
Merge pull request servo#175 from davidalber/dockerize
3ac3889 
Add Dockerfile and other associated files
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
E-Easy
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Cap number of files that are listed in "heads up" comment
3 participants
@jdm @pyfisch @highfive