Shrink our gigantic tests! #115

wafflespeanut · 2016-05-06T14:06:18Z

This makes use of a simple wrapper around the JSON object and marks stuff whenever we 'get' something from the dictionary (using []). This can help shrink the gigantic tests we currently have (which has a hell lot of unused key/val)

highfive · 2016-05-06T14:06:20Z

Heads up! This PR modifies the following files:

@jdm: helpers.py, eventhandler.py, test.py, json_cleanup.py

wafflespeanut · 2016-05-06T14:08:28Z

gotta fix the flake8 stuff...

wafflespeanut · 2016-05-06T14:09:30Z

It might be worth taking a look at the failed Travis build! 😄

wafflespeanut · 2016-05-06T14:13:29Z

@jdm I think it's still buggy, but well, this is just a prototype. I'm curious whether this would be useful if I make it to work.

highfive · 2016-05-07T02:55:47Z

New code was committed to pull request.

wafflespeanut · 2016-05-07T03:02:17Z

Now, this is progress! (still, 3 tests fail)

highfive · 2016-05-08T05:02:36Z

New code was committed to pull request.

wafflespeanut · 2016-05-08T05:04:12Z

All the tests pass now, but I had to put some type conversions to integrate the lint.

wafflespeanut · 2016-05-08T16:12:46Z

After trying to integrate this into highfive (for a while now), I realize that the entire problem lies on creating the tests, where we read the JSON files twice (one for the initial/expected stuff), and the other for payload. I think I should modify the linter to take objects instead of going directly for the file.

highfive · 2016-05-08T17:35:03Z

New code was committed to pull request.

wafflespeanut · 2016-05-08T17:36:57Z

fixed the linter for flagging only the stuff in payload
avoided reading the test JSONs twice
added flag to warn/overwrite the nodes in test files

only the command-line argument is left to go...

highfive · 2016-05-08T17:51:28Z

New code was committed to pull request.

wafflespeanut · 2016-05-08T17:54:15Z

I'm finally satisfied with the output 😄

bors-servo · 2016-05-10T21:42:52Z

☔ The latest upstream changes (presumably #118) made this pull request unmergeable. Please resolve the merge conflicts.

highfive · 2016-05-10T23:01:22Z

New code was committed to pull request.

highfive · 2016-05-11T06:35:38Z

New code was committed to pull request.

highfive · 2016-05-11T07:26:57Z

New code was committed to pull request.

highfive · 2016-05-11T11:57:02Z

New code was committed to pull request.

highfive · 2016-05-11T12:24:29Z

New code was committed to pull request.

wafflespeanut · 2016-05-11T12:26:20Z

This is ready for review!

highfive · 2016-05-16T06:12:18Z

New code was committed to pull request.

highfive · 2016-05-16T06:26:16Z

New code was committed to pull request.

jdm · 2016-05-16T16:57:39Z

handlers/assign_reviewer/__init__.py

@@ -55,7 +55,7 @@ def on_pr_opened(self, api, payload):
        pr = payload["pull_request"]
        # If the pull request already has an assignee,
        # don't try to set one ourselves.
-        if pr["assignee"] != None:
+        if pr["assignee"] != None:      # NOQA (silence flake8 here)


What is it complaining about?

flake8 prefers is not None, but we need != to call our overridden __ne__ method (the former checks for an exact match of the object, which will fail during testing)

jdm · 2016-05-16T17:13:14Z

The need for str(foo) and int(foo) in various places is disappointing. Is there no way around that?

highfive · 2016-05-17T19:24:25Z

New code was committed to pull request.

wafflespeanut · 2016-05-17T19:32:33Z

True, they are bad, but I couldn't find a way around them. I've fixed some of them, and now we have only three situations (in regex matching) where str(foo) occurs. Python's re methods look pretty strict, that they accept only string/unicode, which prevents us from overriding anything 😞

jdm · 2016-05-17T20:06:59Z

Thanks!

wafflespeanut · 2016-05-18T02:45:45Z

Thanks for reviewing it :)

Adding tests for `api_req`

highfive assigned jdm May 6, 2016

highfive added the S-awaiting-review label May 6, 2016

wafflespeanut force-pushed the chop_tests branch from 2b44f8f to e794870 Compare May 7, 2016 02:55

wafflespeanut force-pushed the chop_tests branch from e794870 to 88f34dd Compare May 8, 2016 05:02

wafflespeanut force-pushed the chop_tests branch from 88f34dd to c877682 Compare May 8, 2016 17:34

wafflespeanut force-pushed the chop_tests branch from c877682 to eec2bbc Compare May 8, 2016 17:51

wafflespeanut changed the title ~~[WIP] Shrink our gigantic tests!~~ Shrink our gigantic tests! May 8, 2016

wafflespeanut force-pushed the chop_tests branch from eec2bbc to 25ac3dd Compare May 10, 2016 23:01

wafflespeanut force-pushed the chop_tests branch from 25ac3dd to 8ccdbc2 Compare May 11, 2016 06:35

wafflespeanut force-pushed the chop_tests branch from 8ccdbc2 to d0d9b57 Compare May 11, 2016 07:26

wafflespeanut force-pushed the chop_tests branch from faab8bc to 78536be Compare May 16, 2016 06:12

wafflespeanut force-pushed the chop_tests branch from 78536be to 9371c59 Compare May 16, 2016 06:26

jdm reviewed May 16, 2016
View reviewed changes

wafflespeanut added 5 commits May 18, 2016 00:52

Initial setup of the JSON tests linter

5ddeaf8

Integrate the test lint into the test script

200d7d7

Add a command-line argument for cleaning up the JSONs

a84aaa8

Fix flake8 warnings

56c38b9

Cleaned up the JSON files

e4b650e

wafflespeanut force-pushed the chop_tests branch from 9371c59 to e4b650e Compare May 17, 2016 19:24

jdm merged commit 7f3112c into servo:master May 17, 2016

highfive removed the S-awaiting-merge label May 17, 2016

wafflespeanut deleted the chop_tests branch May 18, 2016 02:33

Mark-Simulacrum pushed a commit to Mark-Simulacrum/highfive that referenced this pull request Sep 8, 2020

Merge pull request servo#115 from davidalber/test-api-req

edc7ebf

Adding tests for `api_req`

Shrink our gigantic tests! #115

Shrink our gigantic tests! #115

Uh oh!

Conversation

wafflespeanut commented May 6, 2016 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

highfive commented May 6, 2016

Uh oh!

wafflespeanut commented May 6, 2016

Uh oh!

wafflespeanut commented May 6, 2016

Uh oh!

wafflespeanut commented May 6, 2016

Uh oh!

highfive commented May 7, 2016

Uh oh!

wafflespeanut commented May 7, 2016

Uh oh!

highfive commented May 8, 2016

Uh oh!

wafflespeanut commented May 8, 2016

Uh oh!

wafflespeanut commented May 8, 2016

Uh oh!

highfive commented May 8, 2016

Uh oh!

wafflespeanut commented May 8, 2016

Uh oh!

highfive commented May 8, 2016

Uh oh!

wafflespeanut commented May 8, 2016

Uh oh!

bors-servo commented May 10, 2016

Uh oh!

highfive commented May 10, 2016

Uh oh!

highfive commented May 11, 2016

Uh oh!

highfive commented May 11, 2016

Uh oh!

highfive commented May 11, 2016

Uh oh!

highfive commented May 11, 2016

Uh oh!

wafflespeanut commented May 11, 2016

Uh oh!

highfive commented May 16, 2016

Uh oh!

highfive commented May 16, 2016

Uh oh!

jdm May 16, 2016

Choose a reason for hiding this comment

Uh oh!

wafflespeanut May 16, 2016 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

jdm commented May 16, 2016 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

highfive commented May 17, 2016

Uh oh!

wafflespeanut commented May 17, 2016 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jdm commented May 17, 2016

Uh oh!

wafflespeanut commented May 18, 2016

Uh oh!

Uh oh!

wafflespeanut commented May 6, 2016 •

edited

Loading

wafflespeanut May 16, 2016 •

edited

Loading

jdm commented May 16, 2016 •

edited

Loading

wafflespeanut commented May 17, 2016 •

edited

Loading