New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow highfive to assign issues on user request #169

Merged
merged 1 commit into from Feb 5, 2017

Conversation

Projects
None yet
4 participants
@wafflespeanut
Member

wafflespeanut commented Jan 29, 2017

@jdm What say if we have something like this? (just asking)

@highfive

This comment has been minimized.

Show comment
Hide comment
@highfive

highfive Jan 29, 2017

Collaborator

Heads up! This PR modifies the following files:

  • @jdm: handlers/watchers/init.py, handlers/status_update/init.py, handlers/no_modify_css_tests/init.py, handlers/easy_info/init.py, handlers/label_watchers/init.py
Collaborator

highfive commented Jan 29, 2017

Heads up! This PR modifies the following files:

  • @jdm: handlers/watchers/init.py, handlers/status_update/init.py, handlers/no_modify_css_tests/init.py, handlers/easy_info/init.py, handlers/label_watchers/init.py
@jdm

This looks like a useful improvement! We should definitely have some tests for it.

Show outdated Hide outdated handlers/easy_info/__init__.py Outdated
Show outdated Hide outdated handlers/easy_info/__init__.py Outdated
Show outdated Hide outdated handlers/easy_info/__init__.py Outdated
Show outdated Hide outdated handlers/easy_info/__init__.py Outdated
@wafflespeanut

This comment has been minimized.

Show comment
Hide comment
@wafflespeanut

wafflespeanut Feb 5, 2017

Member

Thanks. Addressed the comments :)

Member

wafflespeanut commented Feb 5, 2017

Thanks. Addressed the comments :)

if payload['issue']['state'] != 'open':
return
user = payload['comment']['user']['login']

This comment has been minimized.

@jdm

jdm Feb 5, 2017

Member

Let's make sure that the author is not the bot, because the MSG comment body contains the ASSIGN_MSG string and our automated testing doesn't cover this case.

@jdm

jdm Feb 5, 2017

Member

Let's make sure that the author is not the bot, because the MSG comment body contains the ASSIGN_MSG string and our automated testing doesn't cover this case.

This comment has been minimized.

@wafflespeanut

wafflespeanut Feb 5, 2017

Member

Nice catch (How do you even notice these things? 😛)

@wafflespeanut

wafflespeanut Feb 5, 2017

Member

Nice catch (How do you even notice these things? 😛)

This comment has been minimized.

@jdm

jdm Feb 5, 2017

Member

I simulate the universe in my brain when reviewing.

@jdm

jdm Feb 5, 2017

Member

I simulate the universe in my brain when reviewing.

@jdm

This comment has been minimized.

Show comment
Hide comment
@jdm
Member

jdm commented Feb 5, 2017

@bors-servo

This comment has been minimized.

Show comment
Hide comment
@bors-servo

bors-servo Feb 5, 2017

Contributor

📌 Commit 0eadf3a has been approved by jdm

Contributor

bors-servo commented Feb 5, 2017

📌 Commit 0eadf3a has been approved by jdm

@bors-servo

This comment has been minimized.

Show comment
Hide comment
@bors-servo

bors-servo Feb 5, 2017

Contributor

⌛️ Testing commit 0eadf3a with merge 5f95302...

Contributor

bors-servo commented Feb 5, 2017

⌛️ Testing commit 0eadf3a with merge 5f95302...

bors-servo added a commit that referenced this pull request Feb 5, 2017

Auto merge of #169 - Wafflespeanut:easy, r=jdm
Allow highfive to assign issues on user request

@jdm What say if we have something like this? (just asking)
@bors-servo

This comment has been minimized.

Show comment
Hide comment
@bors-servo

bors-servo Feb 5, 2017

Contributor

☀️ Test successful - status-travis
Approved by: jdm
Pushing 5f95302 to master...

Contributor

bors-servo commented Feb 5, 2017

☀️ Test successful - status-travis
Approved by: jdm
Pushing 5f95302 to master...

@bors-servo bors-servo merged commit 0eadf3a into servo:master Feb 5, 2017

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details

@wafflespeanut wafflespeanut deleted the wafflespeanut:easy branch Feb 6, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment