New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore PRs which are WIP or TODO #62

Merged
merged 1 commit into from Sep 24, 2016

Conversation

Projects
None yet
2 participants
@aneeshusa
Member

aneeshusa commented Sep 23, 2016

This feature inspired by GitLab:
https://about.gitlab.com/2016/01/08/feature-highlight-wip/

Not 100% this is the right way to do this.


This change is Reviewable

@aneeshusa aneeshusa changed the title from Ingore PRs which are WIP or TODO to Ignore PRs which are WIP or TODO Sep 23, 2016

Show outdated Hide outdated homu/main.py
state.title.startswith('[{}]'.format(wip_marker))):
if realtime:
state.add_comment(':clipboard: Looks like this PR is still in progress, ignoring approval')
continue

This comment has been minimized.

@Manishearth

Manishearth Sep 24, 2016

Member

this continue is inside another loop

@Manishearth

Manishearth Sep 24, 2016

Member

this continue is inside another loop

This comment has been minimized.

@aneeshusa

aneeshusa Sep 24, 2016

Member

Oops, this used to not have an inner loop, thanks for catching that.

@aneeshusa

aneeshusa Sep 24, 2016

Member

Oops, this used to not have an inner loop, thanks for catching that.

@Manishearth Manishearth merged commit 178c9e2 into servo:master Sep 24, 2016

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment