Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upUse enum rather than bool for controlling serialize #105
+41
−29
Conversation
|
Could you please rebase this so Travis will test it with the latest rustup? |
kmcallister
added a commit
that referenced
this pull request
Mar 5, 2015
Use enum rather than bool for controlling serialize
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
ChrisParis commentedFeb 28, 2015
In servo/servo#5029, @jdm requested an enum rather than bool for indicating whether to serialize a whole node, or only its children. For consistency, I pushed that suggestion all the way down through html5ever, and it looks like this.