Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rust upgrade to rustc 1.0.0-nightly (d17d6e7f1 2015-04-02) #117

Merged
merged 1 commit into from Apr 3, 2015

Conversation

@Ygg01
Copy link
Contributor

Ygg01 commented Apr 3, 2015

Rustup

rustc 1.0.0-nightly (d17d6e7f1 2015-04-02) (built 2015-04-03)

Minor note: make for_c doesn't work. Not sure why.

@kmcallister
Copy link
Contributor

kmcallister commented Apr 3, 2015

Minor note: make for_c doesn't work. Not sure why.

We can't merge the patch with that broken. But you seem to have fixed the problem, going by Travis.

Rustup

rustc --version:
    rustc 1.0.0-nightly (d17d6e7f1 2015-04-02) (built 2015-04-03)
@Ygg01
Copy link
Contributor Author

Ygg01 commented Apr 3, 2015

@kmcallister Initially, my make script misbehaved (most likely due to Rust upgrade), which looked like some random error (something about multiple filenames 😕 ). I didn't saw what the error was, until Travis CI threw an error and then after cargo clean && rm -r /build it started displaying errors correctly.

As far as braces are concerned, when I was cherry-picking I seemed to have missed this edit and had to rewrite it at last minute, forgetting braces. My apologizes.

Ah, so it was the correct solution 😌 . I was feeling a bit worried, because I'm uncertain if make for_c does any testing.

Anyway, squishy, squishy, it's now a single change.

kmcallister added a commit that referenced this pull request Apr 3, 2015
Rust upgrade to rustc 1.0.0-nightly (d17d6e7f1 2015-04-02)
@kmcallister kmcallister merged commit 432d4e1 into servo:master Apr 3, 2015
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@kmcallister
Copy link
Contributor

kmcallister commented Apr 3, 2015

Thanks!

I'm uncertain if make for_c does any testing

It doesn't. :) The C API is incomplete and I haven't written tests yet.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.