Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upUpgrade to rustc 1.0.0-nightly (6790b0e51 2015-04-11) (built 2015-04-12) #124
Conversation
Also disable doctests because of rust-lang/cargo#1512 Note that there weren’t any doctest to run anyway.
| phf = "0.6" | ||
| phf_macros = "0.6" | ||
| phf = "0.7" | ||
| phf_macros = "0.7" |
This comment has been minimized.
This comment has been minimized.
kmcallister
Apr 13, 2015
Contributor
These should go back to = "0" unless there's a reason to keep them pinned.
This comment has been minimized.
This comment has been minimized.
SimonSapin
Apr 13, 2015
Author
Member
Semver says anything goes before 1.0, but Cargo’s extrapolation of it is that any 0.7.x should be compatible with 0.7.y with y <= x, while 0.8 is not. So if phf follows that convention, 0.8 will probably break html5ever while (in a post-Rust-1.0 world) 0.7 will still be available and compatible.
That said, I’ll make them = "0" if you still feel it’s the right thing to do.
This comment has been minimized.
This comment has been minimized.
| } | ||
| }) | ||
| } | ||
|
|
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
SimonSapin
Apr 13, 2015
Author
Member
This is what libsyntax does:
A variant of 'try!' that panics on Err(FatalError). This is used as a crutch on the way towards a non-panic!-prone parser. It should be used for fatal parsing errors; eventually we plan to convert all code using panictry to just use normal try
Right now it’s the same as .unwrap, but the plan is apparently that it should be try! eventually.
This comment has been minimized.
This comment has been minimized.
kmcallister
Apr 16, 2015
Contributor
Ah, can you add a link or reference to that libsyntax code in a comment here? And, is there an associated Rust issue number?
|
Thanks! r=me with the link or reference to libsyntax as mentioned above. |
SimonSapin commentedApr 13, 2015
Also disable doctests because of rust-lang/cargo#1512
Note that there weren’t any doctest to run anyway.
r? @kmcallister