Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upMake the `sink` module an optional feature. #128
Closed
+83
−36
Conversation
|
Maybe they should move to a separate crate, even a separate repo. We just need that crate as a dev-dependency to build the examples and test suite. |
|
Modularize all the things |
|
Updated to move Besides moving the code, the only other change was turning |
Consumers who provide their own sinks (like Servo) probably don't need this module. Removing it reduces compile time by about 20% (a couple of seconds on my laptop).
|
Merged, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
mbrubeck commentedApr 25, 2015
Consumers who provide their own sinks (like Servo) probably don't need this module. Disabling it reduces compile time by about 20% (a couple of seconds on my laptop). Probably reduces final link time and possibly binary size too, but I haven't measured those.
r? @kmcallister