Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Zero copy parsing take 3 #142

Merged
merged 8 commits into from Jun 25, 2015
Merged

Zero copy parsing take 3 #142

merged 8 commits into from Jun 25, 2015

Conversation

@kmcallister
Copy link
Contributor

kmcallister commented Jun 10, 2015

This includes the tendril integration which is desired for document.write. The only missing piece afaik is fixing up the C API (or temporarily disabling it, but I'd rather not).

I won't have time to finish up this PR but I can answer questions for sure.

(Was #141.)

Review on Reviewable

@SimonSapin
Copy link
Member

SimonSapin commented Jun 10, 2015

What do you want to do with https://github.com/kmcallister/tendril ? Maintain it (we send PRs to you), let us fork it and diverge, give us write access, transfer it?

@SimonSapin
Copy link
Member

SimonSapin commented Jun 10, 2015

@SimonSapin
Copy link
Member

SimonSapin commented Jun 11, 2015

I read through futf, tendril, and this PR. It all looks good. There are lots of good ideas in tendril, I like it :)


Review status: all files reviewed, all discussions resolved, some commit checks failed.
Reviewed files:

  • benches/tokenizer.rs @ r1
  • capi/Cargo.toml @ r1
  • capi/include/html5ever.h @ r1
  • capi/src/lib.rs @ r1
  • capi/src/tokenizer.rs @ r1
  • Cargo.toml @ r1
  • dom_sink/Cargo.toml @ r1
  • dom_sink/src/common.rs @ r1
  • dom_sink/src/lib.rs @ r1
  • dom_sink/src/owned_dom.rs @ r1
  • dom_sink/src/rcdom.rs @ r1
  • examples/html2html.rs @ r1
  • examples/noop-tokenize.rs @ r1
  • examples/noop-tree-builder.rs @ r1
  • examples/print-rcdom.rs @ r1
  • examples/print-tree-actions.rs @ r1
  • examples/tokenize.rs @ r1
  • src/driver.rs @ r1
  • src/lib.rs @ r1
  • src/tokenizer/buffer_queue.rs @ r1
  • src/tokenizer/char_ref/mod.rs @ r1
  • src/tokenizer/interface.rs @ r1
  • src/tokenizer/mod.rs @ r1
  • src/tree_builder/actions.rs @ r1
  • src/tree_builder/data.rs @ r1
  • src/tree_builder/interface.rs @ r1
  • src/tree_builder/mod.rs @ r1
  • src/tree_builder/rules.rs @ r1
  • src/tree_builder/types.rs @ r1
  • src/util/smallcharset.rs @ r1
  • src/util/str.rs @ r1
  • tests/serializer.rs @ r1
  • tests/tokenizer.rs @ r1
  • tests/tree_builder.rs @ r1

Comments from the review on Reviewable.io

@kmcallister
Copy link
Contributor Author

kmcallister commented Jun 15, 2015

I think I'll transfer tendril and futf to the Servo org.

@kmcallister
Copy link
Contributor Author

kmcallister commented Jun 15, 2015

Done :)

@SimonSapin
Copy link
Member

SimonSapin commented Jun 15, 2015

Great, thanks!

@SimonSapin
Copy link
Member

SimonSapin commented Jun 16, 2015

@kmcallister the C API changes look good to me, and cargo test --manifest-path capi/Cargo.toml passes (although it runs zero test). What’s missing?

@SimonSapin SimonSapin force-pushed the tendril-v2 branch from 9e4783d to 9ddd9d1 Jun 16, 2015
@SimonSapin SimonSapin force-pushed the tendril-v2 branch from 9ddd9d1 to 3302cb5 Jun 25, 2015
@SimonSapin SimonSapin changed the title Work in progress -- zero copy parsing take 3 Zero copy parsing take 3 Jun 25, 2015
@SimonSapin
Copy link
Member

SimonSapin commented Jun 25, 2015

@bors-servo
Copy link
Contributor

bors-servo commented Jun 25, 2015

📌 Commit 3302cb5 has been approved by SimonSapin

@bors-servo
Copy link
Contributor

bors-servo commented Jun 25, 2015

Testing commit 3302cb5 with merge a2736b4...

bors-servo pushed a commit that referenced this pull request Jun 25, 2015
Zero copy parsing take 3

This includes the [tendril](https://github.com/kmcallister/tendril) integration which is desired for `document.write`. The only missing piece afaik is fixing up the C API (or temporarily disabling it, but I'd rather not).

I won't have time to finish up this PR but I can answer questions for sure.

(Was #141.)

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/html5ever/142)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Jun 25, 2015

☀️ Test successful - travis

@bors-servo bors-servo merged commit 3302cb5 into master Jun 25, 2015
2 of 3 checks passed
2 of 3 checks passed
homu Testing commit 3302cb5 with merge a2736b4...
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@SimonSapin SimonSapin deleted the tendril-v2 branch Jun 25, 2015
@SimonSapin SimonSapin mentioned this pull request Jul 17, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.