Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix dom_sink docs #150

Merged
merged 3 commits into from Jul 13, 2015
Merged

Fix dom_sink docs #150

merged 3 commits into from Jul 13, 2015

Conversation

@SimonSapin
Copy link
Member

SimonSapin commented Jul 13, 2015

@chris-morgan, is that all the things?

Fixes #148.

@chris-morgan
Copy link
Contributor

chris-morgan commented Jul 13, 2015

Probably. Still, with its having been moved to a different crate it might be nice to have mentions of RcDom clarified as belonging to the different crate. But that’s far less important once the docs actually include it!

@SimonSapin
Copy link
Member Author

SimonSapin commented Jul 13, 2015

@bors-servo r+

I’ll gladly take PRs for further docs improvement ;)

@bors-servo
Copy link
Contributor

bors-servo commented Jul 13, 2015

📌 Commit 2790646 has been approved by SimonSapin

@bors-servo
Copy link
Contributor

bors-servo commented Jul 13, 2015

Testing commit 2790646 with merge 744e411...

bors-servo pushed a commit that referenced this pull request Jul 13, 2015
Fix dom_sink docs

@chris-morgan, is that all the things?

Fixes #148.
@bors-servo
Copy link
Contributor

bors-servo commented Jul 13, 2015

☀️ Test successful - travis

@bors-servo bors-servo merged commit 2790646 into master Jul 13, 2015
2 of 3 checks passed
2 of 3 checks passed
homu Testing commit 2790646 with merge 744e411...
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@tetsuharuohzeki tetsuharuohzeki deleted the dom_sink_doc branch Jul 14, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.