Skip to content

/ html5ever

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement <template> #153

Merged
merged 2 commits into from Sep 1, 2015
Merged

Implement <template> #153

merged 2 commits into from Sep 1, 2015
+401 −137

Conversation

@nox
Copy link
Member

nox commented Aug 18, 2015

Review on Reviewable
@nox nox force-pushed the nox:template branch 5 times, most recently from 9854e65 to dd1735b Aug 18, 2015
@bors-servo
Copy link
Contributor

bors-servo commented Aug 18, 2015

☔ The latest upstream changes (presumably #155) made this pull request unmergeable. Please resolve the merge conflicts.
nox added 2 commits Aug 18, 2015
@nox
Introduce rcdom::ElementEnum
66030d5 
Used for data of elements with special behaviour when parsing.
@nox
Implement <template> (fixes #10)
Loading status checks…
1896e23
@nox nox force-pushed the nox:template branch from dd1735b to 1896e23 Aug 18, 2015
@nox nox mentioned this pull request Aug 19, 2015
Closed
src/tree_builder/rules.rs
panic!("FIXME: <template> not implemented");
InTemplate => match_token!(token {
CharacterTokens(_, _) => self.step(InBody, token),
CommentToken(_) => self.step(InBody, token),

This comment has been minimized.

Sign in to view
@SimonSapin

SimonSapin Sep 1, 2015

Member

Is DocTypeToken missing here?

This comment has been minimized.

Sign in to view
@nox

nox Sep 1, 2015

Author Member

DocTypeToken is already implicitly rejected in all insertion modes (see for example the BeforeHtml branch), I just continued that trend.
@SimonSapin
Copy link
Member

SimonSapin commented Sep 1, 2015

@bors-servo r+
@bors-servo
Copy link
Contributor

bors-servo commented Sep 1, 2015

📌 Commit 1896e23 has been approved by SimonSapin
@bors-servo
Copy link
Contributor

bors-servo commented Sep 1, 2015

⌛ Testing commit 1896e23 with merge 093b65b...
bors-servo pushed a commit that referenced this pull request Sep 1, 2015
bors-servo
Auto merge of #153 - nox:template, r=SimonSapin
Loading status checks…
093b65b 
Implement <template>



<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/html5ever/153)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Sep 1, 2015

☀️ Test successful - travis
@bors-servo bors-servo merged commit 1896e23 into servo:master Sep 1, 2015
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
This was referenced Sep 1, 2015
Merged
Merged
@nox nox deleted the nox:template branch Sep 4, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
@nox @bors-servo @SimonSapin
You can’t perform that action at this time.