Skip to content

/ html5ever

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement tokenization of CDATA sections #156

Merged
merged 2 commits into from Sep 1, 2015
Merged

Implement tokenization of CDATA sections #156

merged 2 commits into from Sep 1, 2015

Conversation

@nox
Copy link
Member

nox commented Aug 18, 2015

Review on Reviewable
@nox nox force-pushed the nox:cdata branch 2 times, most recently from ab1ce39 to 92c724c Aug 19, 2015
nox added 2 commits Aug 18, 2015
@nox
Introduce eat_exact!()
c74e3df 
For case-sensitive comparisons.
@nox
Implement tokenization of CDATA sections (fixes #11)
Loading status checks…
435c9fb
@nox nox force-pushed the nox:cdata branch from 92c724c to 435c9fb Sep 1, 2015
@nox
Copy link
Member Author

nox commented Sep 1, 2015

@SimonSapin I made eat() take an Fn.
@SimonSapin

This comment has been minimized.

Sign in to view
Copy link

SimonSapin commented on src/tokenizer/mod.rs in 435c9fb Sep 1, 2015

Why is \0 special here? I don’t see corresponding spec text.

This comment has been minimized.

Sign in to view
Copy link
Owner Author

nox replied Sep 1, 2015

That's specific to h5e, \0 is special in the tokens themselves (see the corresponding branch in emit_char()). If I don't do this, \0 isn't properly handled where CDATA sections are expected.

This comment has been minimized.

Sign in to view
Copy link
Owner Author

nox replied Sep 1, 2015

See also the comment on emit_chars():

// The string must not contain '\0'!
@SimonSapin
Copy link
Member

SimonSapin commented Sep 1, 2015

@bors-servo r+
@bors-servo
Copy link
Contributor

bors-servo commented Sep 1, 2015

📌 Commit 435c9fb has been approved by SimonSapin
@bors-servo
Copy link
Contributor

bors-servo commented Sep 1, 2015

⌛ Testing commit 435c9fb with merge 7f6bdf6...
bors-servo pushed a commit that referenced this pull request Sep 1, 2015
bors-servo
Auto merge of #156 - nox:cdata, r=SimonSapin
Loading status checks…
7f6bdf6 
Implement tokenization of CDATA sections



<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/html5ever/156)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Sep 1, 2015

☀️ Test successful - travis
@bors-servo bors-servo merged commit 435c9fb into servo:master Sep 1, 2015
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
This was referenced Sep 1, 2015
Merged
Merged
@nox nox deleted the nox:cdata branch Sep 4, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
@nox @SimonSapin @bors-servo
You can’t perform that action at this time.