Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upFix <noscript> tests #158
Merged
Fix <noscript> tests #158
+38
−16
Conversation
|
|
Use the expectations' fields script-on and script-off to run the tests with their scripting flag set appropriately.
tests/tree_builder.rs
Outdated
| let ignore = ignores.contains(&name); | ||
| let data = get_field("data"); | ||
| let ignore = ignores.contains(name) | ||
| || IGNORE_SUBSTRS.iter().any(|&ig| data.contains(ig)); |
This comment has been minimized.
This comment has been minimized.
|
Fixed. :) |
|
@bors-servo r+ |
|
|
bors-servo
pushed a commit
that referenced
this pull request
Sep 1, 2015
Fix <noscript> tests Use the expectations' fields script-on and script-off to run the tests with their scripting flag set appropriately. <!-- Reviewable:start --> [<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/html5ever/158) <!-- Reviewable:end -->
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
nox commentedAug 19, 2015
Use the expectations' fields script-on and script-off to run the tests with their scripting flag set appropriately.