Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upRun tree builder and tokenizer tests again. #168
Merged
Conversation
|
The something that changed: https://github.com/rust-lang/rust/blob/19a33edaa956a842fed11a1293a5aa7336483f0c/src/libsyntax/test.rs#L205-L207 #[start] and #[main] are now unconditionally removed. |
|
@bors-servo r+ |
|
|
bors-servo
pushed a commit
that referenced
this pull request
Sep 1, 2015
Run tree builder and tokenizer tests again. Something change in rustc and the #[start] trick doesn’t run anymore. This runs a test harness nested in another. It’s not pretty, but it works. <!-- Reviewable:start --> [<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/html5ever/168) <!-- Reviewable:end -->
|
I forced-pushed a second too late to add it to the commit message :) |
|
@bors-servo r=nox 2dbe7b5 |
bors-servo
pushed a commit
that referenced
this pull request
Sep 1, 2015
Run tree builder and tokenizer tests again. Something change in rustc and the #[start] trick doesn’t run anymore. This runs a test harness nested in another. It’s not pretty, but it works. <!-- Reviewable:start --> [<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/html5ever/168) <!-- Reviewable:end -->
libtest now ignores our #[start] trick: https://github.com/rust-lang/rust/blob/8dba06aeee28e9ed6a1b9918a91cbef242af53d3/src/libsyntax/test.rs#L205-L207 This runs a test harness nested in another. It’s not pretty, but it works.
|
Don’t make tests fail when they can’t be run. |
bors-servo
pushed a commit
that referenced
this pull request
Sep 1, 2015
Run tree builder and tokenizer tests again. Something change in rustc and the #[start] trick doesn’t run anymore. This runs a test harness nested in another. It’s not pretty, but it works. <!-- Reviewable:start --> [<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/html5ever/168) <!-- Reviewable:end -->
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
SimonSapin commentedSep 1, 2015
Something change in rustc and the #[start] trick doesn’t run anymore.
This runs a test harness nested in another. It’s not pretty, but it works.