Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update inline tokenize example #170

Merged
merged 1 commit into from Sep 3, 2015
Merged

Update inline tokenize example #170

merged 1 commit into from Sep 3, 2015

Conversation

@johannhof
Copy link
Contributor

johannhof commented Sep 3, 2015

tokenize_to was at some point changed to move the sink value instead of taking a mut ref, but the inline rustdoc example was not updated, causing lots of confusion

Review on Reviewable

Johann Hofmann
`tokenize_to` was at some point changed to move the `sink` value instead of taking a mut ref, but the inline rustdoc example was not updated, causing lots of confusion
@SimonSapin
Copy link
Member

SimonSapin commented Sep 3, 2015

Thanks!

@bors-servo r+

@bors-servo
Copy link
Contributor

bors-servo commented Sep 3, 2015

📌 Commit a84abfb has been approved by SimonSapin

@bors-servo
Copy link
Contributor

bors-servo commented Sep 3, 2015

Testing commit a84abfb with merge 091b436...

bors-servo pushed a commit that referenced this pull request Sep 3, 2015
Update inline tokenize example

`tokenize_to` was at some point changed to move the `sink` value instead of taking a mut ref, but the inline rustdoc example was not updated, causing lots of confusion

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/html5ever/170)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Sep 3, 2015

☀️ Test successful - travis

@bors-servo bors-servo merged commit a84abfb into servo:master Sep 3, 2015
1 of 2 checks passed
1 of 2 checks passed
homu Testing commit a84abfb with merge 091b436...
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.