Skip to content

/ html5ever

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix version support in README #176

Merged
merged 2 commits into from Oct 12, 2015
Merged

Fix version support in README #176

merged 2 commits into from Oct 12, 2015
+1 −1

Conversation

@sfackler
Copy link
Contributor

sfackler commented Oct 11, 2015

Closes #171

Review on Reviewable
@sfackler
Fix version support in README
Loading status checks…
1fb4c30
@SimonSapin
Copy link
Member

SimonSapin commented Oct 11, 2015

IIRC all features are there, only some optimization (mostly of memory size: NonZero, unsafe_no_drop_flag, …) require Nightly. (And using a compiler-plugin rather than a pre-generated file, but users don’t care, that only matters when modifying that file.)

So, please change "features" to "optimizations" in the patch, and this looks good.
@sfackler
s/features/optimizations/
Loading status checks…
d987e5b
@sfackler
Copy link
Contributor Author

sfackler commented Oct 11, 2015

Ah, thanks for the info, fixed!
@SimonSapin
Copy link
Member

SimonSapin commented Oct 12, 2015

@bors-servo r+
@bors-servo
Copy link
Contributor

bors-servo commented Oct 12, 2015

📌 Commit d987e5b has been approved by SimonSapin
@bors-servo
Copy link
Contributor

bors-servo commented Oct 12, 2015

⌛ Testing commit d987e5b with merge 12e2b60...
bors-servo pushed a commit that referenced this pull request Oct 12, 2015
bors-servo
Auto merge of #176 - sfackler:master, r=SimonSapin
Loading status checks…
12e2b60 
Fix version support in README

Closes #171 

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/html5ever/176)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Oct 12, 2015

☀️ Test successful - travis
@bors-servo bors-servo merged commit d987e5b into servo:master Oct 12, 2015
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
@sfackler @SimonSapin @bors-servo
You can’t perform that action at this time.