Skip to content

/ html5ever

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade string-cache to 0.2. #184

Merged
merged 1 commit into from Nov 23, 2015
Merged

Upgrade string-cache to 0.2. #184

merged 1 commit into from Nov 23, 2015

Conversation

@SimonSapin
Copy link
Member

SimonSapin commented Nov 23, 2015

r? @asajeffrey

Review on Reviewable
@frewsxcv
Copy link
Member

frewsxcv commented Nov 23, 2015

Travis fail in case you missed it
@SimonSapin
Copy link
Member Author

SimonSapin commented Nov 23, 2015

Thank, looking.
@SimonSapin
Upgrade string-cache to 0.2.
Loading status checks…
2334344
@SimonSapin SimonSapin force-pushed the string-cache-up branch from c6048c5 to 2334344 Nov 23, 2015
@asajeffrey
Copy link
Member

asajeffrey commented Nov 23, 2015

Reviewed 22 of 22 files at r1.
Review status: all files reviewed at latest revision, all discussions resolved.

Comments from the review on Reviewable.io
@asajeffrey
Copy link
Member

asajeffrey commented Nov 23, 2015

@bors-servo r+
@bors-servo
Copy link
Contributor

bors-servo commented Nov 23, 2015

🔑 Insufficient privileges
@frewsxcv
Copy link
Member

frewsxcv commented Nov 23, 2015

@bors-servo r=asajeffrey
@bors-servo
Copy link
Contributor

bors-servo commented Nov 23, 2015

📌 Commit 2334344 has been approved by asajeffrey
@bors-servo
Copy link
Contributor

bors-servo commented Nov 23, 2015

⌛ Testing commit 2334344 with merge eac6491...
bors-servo added a commit that referenced this pull request Nov 23, 2015
@bors-servo
Auto merge of #184 - servo:string-cache-up, r=asajeffrey
Loading status checks…
eac6491 
Upgrade string-cache to 0.2.

r? @asajeffrey

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/html5ever/184)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Nov 23, 2015

☀️ Test successful - travis
@bors-servo bors-servo merged commit 2334344 into master Nov 23, 2015
4 checks passed
4 checks passed
code-review/reviewable Review complete: all files reviewed, all discussions resolved
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
homu Test successful
Details
@SimonSapin SimonSapin deleted the string-cache-up branch Nov 23, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
@SimonSapin @frewsxcv @asajeffrey @bors-servo
You can’t perform that action at this time.