Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upRemove blank line after serializing doctype #206
Merged
Conversation
|
This matches my reading of https://html.spec.whatwg.org/multipage/syntax.html#serialising-html-fragments, which is good. Oddly, I don't see any historical reason for including the newline when looking at older revisions of the specification, even around the time that this was originally implemented. |
|
@bors-servo: r+ |
|
|
bors-servo
added a commit
that referenced
this pull request
Apr 14, 2016
Remove blank line after serializing doctype As said here [1], the line break after the doctype is undesirable. [1] servo/servo#10604 (comment) <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/html5ever/206) <!-- Reviewable:end -->
|
|
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
jaysonsantos commentedApr 14, 2016
As said here [1], the line break after the doctype is undesirable.
[1] servo/servo#10604 (comment)
This change is