Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make get_template_contents take a mutable self argument. #209

Merged
merged 1 commit into from Apr 26, 2016

Conversation

@jdm
Copy link
Member

jdm commented Apr 26, 2016

This change is Reviewable

@SimonSapin
Copy link
Member

SimonSapin commented Apr 26, 2016

Seems reasonable, but out of curiosity: why?

@KiChjang
Copy link
Member

KiChjang commented Apr 26, 2016

<jdm> KiChjang: it would make a bunch of code in https://github.com/servo/servo/compare/master...jdm:asyncparse much nicer
@SimonSapin
Copy link
Member

SimonSapin commented Apr 26, 2016

@bors-servo
Copy link
Contributor

bors-servo commented Apr 26, 2016

📌 Commit 153c146 has been approved by SimonSapin

@bors-servo
Copy link
Contributor

bors-servo commented Apr 26, 2016

Testing commit 153c146 with merge 6afdb4e...

bors-servo added a commit that referenced this pull request Apr 26, 2016
Make get_template_contents take a mutable self argument.

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/html5ever/209)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Apr 26, 2016

☀️ Test successful - travis

@bors-servo bors-servo merged commit 153c146 into servo:master Apr 26, 2016
1 of 2 checks passed
1 of 2 checks passed
homu Testing commit 153c146 with merge 6afdb4e...
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.