Skip to content

/ html5ever

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use std::time instead of deprecated crate time #213

Merged
merged 2 commits into from Aug 21, 2016
Merged

Use std::time instead of deprecated crate time #213

merged 2 commits into from Aug 21, 2016
+3 −5

Conversation

@spk
Copy link
Contributor

spk commented Aug 20, 2016 •
edited by larsbergstrom

Crate time is deprecated; switch to std::time
Cheers

This change is Reviewable
@spk
Use std::time instead of deprecated crate time
Verified
This commit was signed with a verified signature.
spk Laurent Arnoud
GPG key ID: A79DAB2374F95DD5 Learn about signing commits
Loading status checks…
2f3ceec
@jdm
Copy link
Member

jdm commented Aug 20, 2016

This change reduces the accuracy of the timer from nanoseconds to seconds, which is much less useful. Can we improve on that?
@SimonSapin
Copy link
Member

SimonSapin commented Aug 20, 2016

I’m making a PR to Rust’s standard library to add a Duration method doing this, but in the meantime please use d.as_secs() * 1_000_000_000 + u64::from(d.subsec_nanos())
@SimonSapin
Copy link
Member

SimonSapin commented Aug 21, 2016

rust-lang/rust#35868
@spk
Use nanos duration on time macro
Verified
This commit was signed with a verified signature.
spk Laurent Arnoud
GPG key ID: A79DAB2374F95DD5 Learn about signing commits
Loading status checks…
c377068 
Thanks-to: @SimonSapin
@SimonSapin
Copy link
Member

SimonSapin commented Aug 21, 2016

@bors-servo r+
@bors-servo
Copy link
Contributor

bors-servo commented Aug 21, 2016

📌 Commit c377068 has been approved by SimonSapin
@bors-servo
Copy link
Contributor

bors-servo commented Aug 21, 2016

⌛ Testing commit c377068 with merge d4cd4d4...
bors-servo added a commit that referenced this pull request Aug 21, 2016
@bors-servo
Auto merge of #213 - spk:remove-crate-time, r=SimonSapin
Loading status checks…
d4cd4d4 
Use std::time instead of deprecated crate time

Crate time is deprecated; switch to `std::time`
Cheers

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/html5ever/213)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Aug 21, 2016

☀️ Test successful - status-travis
@bors-servo bors-servo merged commit c377068 into servo:master Aug 21, 2016
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
@spk spk deleted the spk:remove-crate-time branch Sep 5, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
@spk @jdm @SimonSapin @bors-servo
You can’t perform that action at this time.