Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upfix benchmarking broken by "Make tokenizer not own the input stream" #227
+5
−1
Conversation
|
r? @nox |
|
Oops, thanks! @bors-servo r+ |
|
|
|
|
bors-servo
added a commit
that referenced
this pull request
Nov 2, 2016
fix benchmarking broken by "Make tokenizer not own the input stream" Was curious about project benchmarks and noticed it was broken. A quick bisect revealed it was recently broken in 7fec1da. Thankfully there was examples of testing that needed to be updated which correlated directly. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/html5ever/227) <!-- Reviewable:end -->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
jackinloadup commentedNov 2, 2016
•
edited by larsbergstrom
Was curious about project benchmarks and noticed it was broken. A quick bisect revealed it was recently broken in 7fec1da. Thankfully there was examples of testing that needed to be updated which correlated directly.
This change is