Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upAdd more interned strings; bump version. #230
Merged
Conversation
|
@bors-servo r+ Looks fine, but note Servo doesn’t use this crate yet. (I have a branch where it does, but other things need to land before I can land it.) So what motivates this change? |
|
|
|
|
bors-servo
added a commit
that referenced
this pull request
Nov 3, 2016
Add more interned strings; bump version. <!-- Reviewable:start --> This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/html5ever/230) <!-- Reviewable:end -->
(From the git commit message) servo/servo#14036 |
|
servo/servo#14043 is in the CI queue, so soon enough you should be able to rebase your Servo PR and run |
frewsxcv
added a commit
to frewsxcv/servo
that referenced
this pull request
Nov 3, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
frewsxcv commentedNov 3, 2016
•
edited by larsbergstrom
This change is