Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TreeBuilder no longer relies on `same_tree` and `has_parent_node` #300

Merged
merged 1 commit into from Aug 17, 2017

Conversation

@cynicaldevil
Copy link
Contributor

cynicaldevil commented Aug 12, 2017

The use of same_tree and has_parent_node meant that the TreeBuilder needed access to the DOM state to carry out its tasks.

@cynicaldevil cynicaldevil force-pushed the cynicaldevil:remove-dep-on-sync-methods branch from d8c2ea5 to 9d332e7 Aug 12, 2017
@cynicaldevil

This comment has been minimized.

Copy link
Contributor Author

cynicaldevil commented Aug 13, 2017

cc @nox

@cynicaldevil cynicaldevil force-pushed the cynicaldevil:remove-dep-on-sync-methods branch from 9d332e7 to 92b7954 Aug 13, 2017
@cynicaldevil cynicaldevil force-pushed the cynicaldevil:remove-dep-on-sync-methods branch from 92b7954 to 307f14c Aug 13, 2017
@nox

This comment has been minimized.

Copy link
Member

nox commented Aug 17, 2017

@bors-servo

This comment has been minimized.

Copy link
Contributor

bors-servo commented Aug 17, 2017

📌 Commit 307f14c has been approved by nox

bors-servo added a commit that referenced this pull request Aug 17, 2017
TreeBuilder no longer relies on `same_tree` and `has_parent_node`

The use of `same_tree` and `has_parent_node` meant that the TreeBuilder needed access to the DOM state to carry out its tasks.
@bors-servo

This comment has been minimized.

Copy link
Contributor

bors-servo commented Aug 17, 2017

⌛️ Testing commit 307f14c with merge f4048cb...

@bors-servo

This comment has been minimized.

Copy link
Contributor

bors-servo commented Aug 17, 2017

☀️ Test successful - status-travis
Approved by: nox
Pushing f4048cb to master...

@bors-servo bors-servo merged commit 307f14c into servo:master Aug 17, 2017
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
@cynicaldevil cynicaldevil deleted the cynicaldevil:remove-dep-on-sync-methods branch Oct 3, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.