Skip to content

/ html5ever

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update `syn`, `quote` and `proc-macro2` #341

Merged
merged 2 commits into from Apr 10, 2018
Merged

Update `syn`, `quote` and `proc-macro2` #341

merged 2 commits into from Apr 10, 2018

Conversation

@hcpl
Copy link
Contributor

hcpl commented Apr 1, 2018 •
edited by SimonSapin

This change is Reviewable
@hcpl
Update `syn`, `quote` and `proc-macro2`
Loading status checks…
d367c14
@SimonSapin SimonSapin mentioned this pull request Apr 1, 2018
Closed
4 of 4 tasks complete
@SimonSapin
Copy link
Member

SimonSapin commented Apr 1, 2018

Let’s coordinate this with other Servo dependencies: servo/servo#20497
@SimonSapin
Copy link
Member

SimonSapin commented Apr 10, 2018 •
edited

Please remove the three imports of AsciiExt in order to fix compilation on Rust Nightly, and increment the html5ever version number to 0.22.2. Thanks!

Reviewed 1 of 1 files at r1.
Review status: all files reviewed at latest revision, all discussions resolved, some commit checks failed.

Comments from Reviewable
@hcpl
Copy link
Contributor Author

hcpl commented Apr 10, 2018

I also found several AsciiExt imports in markup5ever and xml5ever, should I remove from there and increment their versions too?
@SimonSapin
Copy link
Member

SimonSapin commented Apr 10, 2018

Yes for removing them, but I think there’s no need for the version numbers because warnings are inhibited when compiling a library as a dependency.
@hcpl
Increment version number of `html5ever`
Loading status checks…
cb08579 
Also removes all uses of `AsciiExt` in the codebase including
`markup5ever` and `xml5ever`.
@SimonSapin
Copy link
Member

SimonSapin commented Apr 10, 2018

@bors-servo r+

Reviewed 8 of 8 files at r2.
Review status: all files reviewed at latest revision, all discussions resolved.

Comments from Reviewable
@bors-servo
Copy link
Contributor

bors-servo commented Apr 10, 2018

📌 Commit cb08579 has been approved by SimonSapin
@bors-servo
Copy link
Contributor

bors-servo commented Apr 10, 2018

⌛ Testing commit cb08579 with merge 6e2129e...
bors-servo added a commit that referenced this pull request Apr 10, 2018
@bors-servo
Auto merge of #341 - hcpl:update-syn-quote-proc-macro2, r=SimonSapin
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
6e2129e 
Update `syn`, `quote` and `proc-macro2`

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/html5ever/341)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Apr 10, 2018

☀️ Test successful - status-travis
Approved by: SimonSapin
Pushing 6e2129e to master...
@bors-servo bors-servo merged commit cb08579 into servo:master Apr 10, 2018
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
@hcpl @SimonSapin @bors-servo
You can’t perform that action at this time.