Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

markup5ever: Move BufferQueue tests into that module. #347

Merged
merged 1 commit into from Dec 13, 2018

Conversation

jimblandy
Copy link
Contributor

The tests in the top-level lib.rs file of markup5ever exercise only BufferQueue, so it seems like it would be clearer for them to live in util/buffer_queue.rs.

@jdm
Copy link
Member

jdm commented Dec 13, 2018

@bors-servo r+

@bors-servo
Copy link
Contributor

📌 Commit 4d0df38 has been approved by jdm

bors-servo pushed a commit that referenced this pull request Dec 13, 2018
markup5ever: Move BufferQueue tests into that module.

The tests in the top-level `lib.rs` file of `markup5ever` exercise only `BufferQueue`, so it seems like it would be clearer for them to live in `util/buffer_queue.rs`.
@bors-servo
Copy link
Contributor

⌛ Testing commit 4d0df38 with merge 95c374e...

@bors-servo
Copy link
Contributor

☀️ Test successful - status-travis
Approved by: jdm
Pushing 95c374e to master...

@bors-servo bors-servo merged commit 4d0df38 into servo:master Dec 13, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants