Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Serialize rcdom iteratively #372

Merged
merged 4 commits into from Apr 27, 2019
Merged

Serialize rcdom iteratively #372

merged 4 commits into from Apr 27, 2019

Conversation

@jdm
Copy link
Member

jdm commented Apr 26, 2019

Fixes #371.

@Manishearth
Copy link
Member

Manishearth commented Apr 26, 2019

@bors-servo
Copy link
Contributor

bors-servo commented Apr 26, 2019

📌 Commit 19eba5d has been approved by Manishearth

@bors-servo
Copy link
Contributor

bors-servo commented Apr 26, 2019

Testing commit 19eba5d with merge 639b65b...

bors-servo added a commit that referenced this pull request Apr 26, 2019
Serialize rcdom iteratively

Fixes #371.
@bors-servo
Copy link
Contributor

bors-servo commented Apr 26, 2019

💔 Test failed - checks-travis

@jdm jdm force-pushed the iterate branch from 19eba5d to ebfffde Apr 26, 2019
@jdm
Copy link
Member Author

jdm commented Apr 26, 2019

@bors-servo r=Manishearth

@bors-servo
Copy link
Contributor

bors-servo commented Apr 26, 2019

📌 Commit ebfffde has been approved by Manishearth

@bors-servo
Copy link
Contributor

bors-servo commented Apr 26, 2019

Testing commit ebfffde with merge 16c0243...

bors-servo added a commit that referenced this pull request Apr 26, 2019
Serialize rcdom iteratively

Fixes #371.
@bors-servo
Copy link
Contributor

bors-servo commented Apr 27, 2019

💔 Test failed - checks-travis

@CYBAI
Copy link

CYBAI commented Apr 27, 2019

Maybe markup5ever's version in both html5ever and xml5ever needs to be updated as well 👀?

+cargo bench --all
    Updating crates.io index
error: failed to select a version for the requirement `markup5ever = "^0.7"`
  candidate versions found which didn't match: 0.8.0
  location searched: /home/travis/build/servo/html5ever/markup5ever
required by package `html5ever v0.22.7 (/home/travis/build/servo/html5ever/html5ever)`
The command "scripts/travis-build.sh" exited with 101.
@jdm jdm force-pushed the iterate branch from ebfffde to 014b3ce Apr 27, 2019
@jdm
Copy link
Member Author

jdm commented Apr 27, 2019

@bors-servo r=manishearth

@bors-servo
Copy link
Contributor

bors-servo commented Apr 27, 2019

📌 Commit 014b3ce has been approved by manishearth

@bors-servo
Copy link
Contributor

bors-servo commented Apr 27, 2019

Testing commit 014b3ce with merge 121523b...

bors-servo added a commit that referenced this pull request Apr 27, 2019
Serialize rcdom iteratively

Fixes #371.
@bors-servo
Copy link
Contributor

bors-servo commented Apr 27, 2019

☀️ Test successful - checks-travis
Approved by: manishearth
Pushing 121523b to master...

@bors-servo bors-servo merged commit 014b3ce into master Apr 27, 2019
3 checks passed
3 checks passed
Travis CI - Branch Build Passed
Details
Travis CI - Pull Request Build Passed
Details
homu Test successful
Details
bors-servo added a commit that referenced this pull request May 3, 2019
Expose public Node constructor.

Since #372 there is a private field in Node that prevents constructing them manually. If we want to support that, we need to expose the constructor.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

4 participants
You can’t perform that action at this time.