Skip to content

/ html5ever

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose public Node constructor. #374

Merged
merged 2 commits into from May 3, 2019
Merged

Expose public Node constructor. #374

merged 2 commits into from May 3, 2019
+4 −4

Conversation

@jdm
Copy link
Member

jdm commented May 2, 2019

Since #372 there is a private field in Node that prevents constructing them manually. If we want to support that, we need to expose the constructor.
@jdm
Expose public Node constructor.
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
52f3091
@jdm
Copy link
Member Author

jdm commented May 2, 2019

@SimonSapin Do you have any thoughts about this?
@jdm jdm mentioned this pull request May 2, 2019
Closed
@SimonSapin
Copy link
Member

SimonSapin commented May 2, 2019

It sounds like 0.22.8 was a breaking change and should have been published as 0.23.0 instead, per Semantic Versioning. Now I think we should yank 0.22.8 and publish 0.23.0 with this PR (since rcdom becomes less useful if nodes cannot be created except through the parser).

r+ with the version number bump to three crates.

(Or, if we don’t want to have to deal with migrating the ecosystem, let’s find a way to not add fields to rctree::Node.)
@jdm
Copy link
Member Author

jdm commented May 2, 2019

Yeah, I didn't realize that we re-export RcDom in both html5ever and xml5ever, so I only did a semver-major bump for markup5ever. I'll follow your suggestion.
@jdm jdm mentioned this pull request May 3, 2019
Closed
@jdm
Perform major version bump for xml5ever and html5ever.
Loading status checks…
1f86279
@jdm
Copy link
Member Author

jdm commented May 3, 2019

@bors-servo r=SimonSapin
@bors-servo
Copy link
Contributor

bors-servo commented May 3, 2019

📌 Commit 1f86279 has been approved by SimonSapin
bors-servo added a commit that referenced this pull request May 3, 2019
@bors-servo
Auto merge of #374 - servo:jdm-patch-3, r=SimonSapin
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
284953e 
Expose public Node constructor.

Since #372 there is a private field in Node that prevents constructing them manually. If we want to support that, we need to expose the constructor.
@bors-servo
Copy link
Contributor

bors-servo commented May 3, 2019

⌛ Testing commit 1f86279 with merge 284953e...
@bors-servo
Copy link
Contributor

bors-servo commented May 3, 2019

☀️ Test successful - checks-travis
Approved by: SimonSapin
Pushing 284953e to master...
@bors-servo bors-servo merged commit 1f86279 into master May 3, 2019
3 checks passed
3 checks passed
Travis CI - Branch Build Passed
Details
Travis CI - Pull Request Build Passed
Details
homu Test successful
Details
@notriddle notriddle deleted the jdm-patch-3 branch May 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
@jdm @SimonSapin @bors-servo
You can’t perform that action at this time.