Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure all RcDom nodes drop children iteratively #384

Merged
merged 2 commits into from
Jul 21, 2019
Merged

Conversation

jdm
Copy link
Member

@jdm jdm commented Jul 21, 2019

This is a better solution for the problem solved by 8bf65ef which doesn't require destroying all nodes when the RcDom is dropped. Fixes #383.

@jdm
Copy link
Member Author

jdm commented Jul 21, 2019

r? @Manishearth

@Manishearth
Copy link
Member

@bors-servo r+

@bors-servo
Copy link
Contributor

📌 Commit 10c0e85 has been approved by Manishearth

@bors-servo
Copy link
Contributor

⌛ Testing commit 10c0e85 with merge c538147...

bors-servo pushed a commit that referenced this pull request Jul 21, 2019
Ensure all RcDom nodes drop children iteratively

This is a better solution for the problem solved by 8bf65ef which doesn't require destroying all nodes when the RcDom is dropped. Fixes #383.
@bors-servo
Copy link
Contributor

☀️ Test successful - checks-travis
Approved by: Manishearth
Pushing c538147 to master...

@bors-servo bors-servo merged commit 10c0e85 into master Jul 21, 2019
bors-servo added a commit that referenced this pull request Jun 6, 2020
Drop template contents interatively.

This is an extension of the work from #384.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Drop of RcDom unexpectedly empties all Nodes
3 participants