Skip to content

/ html5ever

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure all RcDom nodes drop children iteratively #384

Merged
merged 2 commits into from Jul 21, 2019
Merged

Ensure all RcDom nodes drop children iteratively #384

merged 2 commits into from Jul 21, 2019

Conversation

@jdm
Copy link
Member

jdm commented Jul 21, 2019

This is a better solution for the problem solved by 8bf65ef which doesn't require destroying all nodes when the RcDom is dropped. Fixes #383.
jdm added 2 commits Jul 21, 2019
@jdm
Ensure all rcdom nodes are destroyed iterately.
81ea581
@jdm
Major version bumps for markup5ever, html5ever, and xml5ever.
Loading status checks…
10c0e85
@jdm
Copy link
Member Author

jdm commented Jul 21, 2019

r? @Manishearth
@jdm jdm mentioned this pull request Jul 21, 2019
Merged
@Manishearth
Copy link
Member

Manishearth commented Jul 21, 2019

@bors-servo r+
@bors-servo
Copy link
Contributor

bors-servo commented Jul 21, 2019

📌 Commit 10c0e85 has been approved by Manishearth
@bors-servo
Copy link
Contributor

bors-servo commented Jul 21, 2019

⌛ Testing commit 10c0e85 with merge c538147...
bors-servo added a commit that referenced this pull request Jul 21, 2019
@bors-servo
Auto merge of #384 - servo:dropfix, r=Manishearth
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
c538147 
Ensure all RcDom nodes drop children iteratively

This is a better solution for the problem solved by 8bf65ef which doesn't require destroying all nodes when the RcDom is dropped. Fixes #383.
@bors-servo
Copy link
Contributor

bors-servo commented Jul 21, 2019

☀️ Test successful - checks-travis
Approved by: Manishearth
Pushing c538147 to master...
@bors-servo bors-servo merged commit 10c0e85 into master Jul 21, 2019
3 checks passed
3 checks passed
Travis CI - Branch Build Passed
Details
Travis CI - Pull Request Build Passed
Details
homu Test successful
Details
@jdm jdm mentioned this pull request Jun 6, 2020
Merged
bors-servo added a commit that referenced this pull request Jun 6, 2020
@bors-servo
Auto merge of #416 - servo:rcdom-template, r=Manishearth
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
ecdfe69 
Drop template contents interatively.

This is an extension of the work from #384.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

Drop of RcDom unexpectedly empties all Nodes
3 participants
@jdm @Manishearth @bors-servo
You can’t perform that action at this time.