Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update phf to 0.10 #461

Merged
merged 1 commit into from Feb 23, 2022
Merged

Update phf to 0.10 #461

merged 1 commit into from Feb 23, 2022

Conversation

xfix
Copy link
Contributor

@xfix xfix commented Jan 2, 2022

No description provided.

@shepmaster
Copy link

@shepmaster shepmaster commented Feb 22, 2022

It would be wonderful if this could be merged and released as it would incidentally resolve integer32llc/rust-playground#780

@@ -15,10 +15,10 @@ path = "lib.rs"

[dependencies]
string_cache = "0.8"
phf = "0.9"
phf = "0.10"

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One thing I've done before when the code didn't need to change at all is to have a wide version range:

- phf = "0.9"
+ phf = { version = ">= 0.9, < 0.11" }

Copy link
Contributor Author

@xfix xfix Feb 23, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This wouldn't really be correct. Because phf has a phf_codegen crate it's possible for Cargo to resolve phf 0.9 and phf_codegen 0.10, which could possibly be bad.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That would be the responsibility of the phf crate to specify which phf_codegen crate it needs.

If this crate allowed phf {0.8,0.9,0.10} then Cargo could pick any one of those, then would resolve the dependencies for the version it picked.

Copy link
Contributor Author

@xfix xfix Feb 24, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

phf_codegen is a build-dependency for this crate (see below), and there would be nothing stopping Cargo from picking a different version here. As far Cargo is concerned those crates are unrelated.

@jdm
Copy link
Member

@jdm jdm commented Feb 22, 2022

@bors-servo r+

@bors-servo
Copy link
Contributor

@bors-servo bors-servo commented Feb 22, 2022

📌 Commit 9a35c1b has been approved by jdm

@bors-servo
Copy link
Contributor

@bors-servo bors-servo commented Feb 22, 2022

Testing commit 9a35c1b with merge 7ca7992...

@bors-servo
Copy link
Contributor

@bors-servo bors-servo commented Feb 23, 2022

☀️ Test successful - checks-github
Approved by: jdm
Pushing 7ca7992 to master...

@bors-servo bors-servo merged commit 7ca7992 into servo:master Feb 23, 2022
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants