Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use trace!() in tokenizer, to reduce log spam #466

Merged
merged 1 commit into from Feb 16, 2022
Merged

Conversation

alsuren
Copy link
Contributor

@alsuren alsuren commented Feb 16, 2022

html5ever doesn't currently use trace!() anywhere. This patch
downgrades a few of the noisiest debug!() calls to use trace!()
instead.

This seems like a more reasonable log level for a tokenizer.

This makes configuring env_logger to debug other code easier
(RUST_LOG=debug rather than RUST_LOG=html5ever=info,debug), and
makes working with minimal wasm log frameworks like console_log
nicer (the console_log crate doesn't have a way to set different
levels for different log prefixes).

There is a single debug statement in html5ever/src/tokenizer/mod.rs that I've not changed:

    debug!("processing EOF in state {:?}", self.state);

I didn't change this to trace, because I notice this log line anywhere in my logs. If you want me to change this too, then I can.

I'm also happy to close this PR, if you think it's not appropriate.

html5ever doesn't currently use trace!() anywhere. This patch
downgrades a few of the noisiest debug!() calls to use trace!()
instead.

This seems like a more reasonable log level for a tokenizer.

This makes configuring env_logger to debug other code easier
(RUST_LOG=debug rather than RUST_LOG=html5ever=info,debug), and
makes working with minimal wasm log frameworks like console_log
nicer (the console_log crate doesn't have a way to set different
levels for different log prefixes).
jdm
jdm approved these changes Feb 16, 2022
@jdm
Copy link
Member

@jdm jdm commented Feb 16, 2022

@bors-servo r+
Thanks!

@bors-servo
Copy link
Contributor

@bors-servo bors-servo commented Feb 16, 2022

📌 Commit 3cf2fb1 has been approved by jdm

@bors-servo
Copy link
Contributor

@bors-servo bors-servo commented Feb 16, 2022

Testing commit 3cf2fb1 with merge adf4485...

@bors-servo
Copy link
Contributor

@bors-servo bors-servo commented Feb 16, 2022

☀️ Test successful - checks-github
Approved by: jdm
Pushing adf4485 to master...

@bors-servo bors-servo merged commit adf4485 into servo:master Feb 16, 2022
1 check passed
@bors-servo bors-servo mentioned this pull request Feb 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants