Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upUse Cargo to build and run tests and benchmarks #78
+103
−157
Conversation
|
Needs a rebase. |
aroben
force-pushed the
aroben:cargoize-tests
branch
2 times, most recently
from
d945f1e
to
5f91cb8
|
Updated and passing CI. |
aroben
changed the title
|
Just updated to also make |
|
Needs a rebase. |
|
Rebased! |
Makefile.in
Outdated
|
|
||
| .PHONY: clean | ||
| clean: | ||
| (cd $(VPATH) && cargo clean) | ||
| rm -f *.o *.a *.so *.dylib *.dll *.dummy *-test *-bench $(EXAMPLES) | ||
| rm -f *.o *.a *.so *.dylib *.dll *.dummy $(EXAMPLES) |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
aroben
force-pushed the
aroben:cargoize-tests
branch
3 times, most recently
from
a583489
to
7a39796
|
Rebased once again. |
|
But now |
|
Yep, I just landed a patch to rustc that breaks all use of compiler plugins ^_^ |
html5ever-external-test.rs is now gone. Its custom test runner has moved into tokenizer.rs and tree_builder.rs. We're using the #[start] attribute to define our own entry point (#[main] isn't respected for tests) which generates the test cases and calls through to test::test_main. tests/util.rs now lives in its own test_util crate. It's the only way I could figure out to share this functionality between the tokenizer and tree builder integration tests. Makefile.in is now a little simpler because we can just use `cargo test` to handle building the tests and examples and and running the tests. Top-level make targets like `build`, `check`, and `examples` continue to work (though `make examples` also builds the tests now).
This is quite similar to the cargoization of tests in the previous commit. html5ever-external-bench is now gone. benches/tokenizer.rs includes its own test harness that calls through to test::test_main.
|
Rebased again. |
|
Thanks! |
kmcallister
added a commit
that referenced
this pull request
Feb 16, 2015
Use Cargo to build and run tests and benchmarks
|
Yay! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
aroben commentedJan 30, 2015
html5ever-external-testandhtml5ever-external-benchare now gone. Their custom test runners have moved into the individual test/bench files. We're using the#[start]attribute to define our own entry point (#[main]isn't respected for tests) which generates the test cases and calls through totest::test_main.tests/util.rsnow lives in its owntest_utilcrate. It's the only way I could figure out to share this functionality between the tokenizer and tree builder integration tests.Makefile.inis now a little simpler because we can just usecargo testto handle building the tests and examples and and running the tests, andcargo benchfor building and running the benches. Top-level make targets likebuild,check, andexamplescontinue to work (thoughmake examplesalso builds the tests now).Fixes #31.