Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upRustup and merge some PRs #79
Merged
+108
−106
Conversation
We now wait to split the input until each test actually runs. This means some duplication of work between tests that previously used the same input, but reduces startup overhead by not performing Vec copies. This makes running a single test significantly faster without affecting the total time to run all tests. Before: $ HTML5EVER_SRC_DIR=$(pwd) time -p ./build/html5ever-external-test --help > /dev/null real 9.75 user 9.64 sys 0.10 $ HTML5EVER_SRC_DIR=$(pwd) time -p ./build/html5ever-external-test > /dev/null real 17.72 user 60.12 sys 3.72 After: $ HTML5EVER_SRC_DIR=$(pwd) time -p ./build/html5ever-external-test --help > /dev/null real 0.51 user 0.49 sys 0.01 $ HTML5EVER_SRC_DIR=$(pwd) time -p ./build/html5ever-external-test > /dev/null real 11.30 user 61.63 sys 4.00
We were always appending them to the <html> element instead of to the "appropriate place".
We are supposed to check whether the parent of the <option> is an <optgroup>. Instead we were checking whether the child of the <html> is an <optgroup>, which I don't believe is even possible.
|
r+ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
kmcallister commentedJan 31, 2015
r? @Manishearth
r=me on the commits that aren't mine :)