Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shrink test output in CI #83

Merged
merged 3 commits into from Feb 4, 2015
Merged

Shrink test output in CI #83

merged 3 commits into from Feb 4, 2015

Conversation

@aroben
Copy link
Contributor

aroben commented Feb 2, 2015

Travis CI won't display build logs longer than 10,000 lines. Since we have so many tests, our CI logs get truncated and you can't see the test failures down at the end of the log.

Instead of printing each test on its own line, we now just print out a single character for each test indiciating success (.), failure (F), or that the test was ignored (I). Failing tests are still printed in full at the end of the test run.

@aroben aroben changed the title Shrink `cargo test` output in CI Shrink test output in CI Feb 2, 2015
@aroben aroben force-pushed the aroben:shorter-ci-output branch from 0518b1f to 074ddc4 Feb 2, 2015
@aroben
Copy link
Contributor Author

aroben commented Feb 2, 2015

Here's an example build with a failing test: https://travis-ci.org/servo/html5ever/builds/49209191

And an example build with all passing (or ignored) tests: https://travis-ci.org/servo/html5ever/builds/49209313

@kmcallister
Copy link
Contributor

kmcallister commented Feb 2, 2015

Nice trick :)

Can you move the output condenser script to scripts/ so it's easier to use outside of Travis? (Also, I'd prefer Python over Perl, but either is fine really.)

@aroben aroben force-pushed the aroben:shorter-ci-output branch from 074ddc4 to 1610d33 Feb 3, 2015
@aroben
Copy link
Contributor Author

aroben commented Feb 3, 2015

OK, I moved it to a separate Python script.

@aroben aroben force-pushed the aroben:shorter-ci-output branch 2 times, most recently from 67dfa69 to 736103c Feb 3, 2015
@aroben
Copy link
Contributor Author

aroben commented Feb 3, 2015

Uh oh, the build "succeeded" even though compiling failed. Guess we need to get the exit status of make rather than the exit status of the script.

aroben added 3 commits Feb 2, 2015
Travis CI won't display build logs longer than 10,000 lines. Since we
have so many tests, our CI logs get truncated and you can't see the test
failures down at the end of the log.

Instead of printing each test on its own line, we now just print out a
single character for each test indiciating success (.), failure (F), or
that the test was ignored (I). Failing tests are still printed in full
at the end of the test run.
Piping `make`'s output through `shrink-test-output.py` was swallowing
`make`'s exit code. Now we explicitly use its exit code for the overall
result of the build.
@aroben aroben force-pushed the aroben:shorter-ci-output branch from 419df6d to 6382bda Feb 3, 2015
@aroben
Copy link
Contributor Author

aroben commented Feb 3, 2015

The exit code issue is fixed. Let me know what you think. Maybe this is too much complexity for the benefit?

@kmcallister kmcallister merged commit 6382bda into servo:master Feb 4, 2015
1 check failed
1 check failed
continuous-integration/travis-ci The Travis CI build failed
Details
@kmcallister
Copy link
Contributor

kmcallister commented Feb 4, 2015

Looks great, thanks :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.