Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upGuard against null pointers (which can exist if the size is zero) in #10
Conversation
`MachSharedMemory::clone()` and `MachSharedMemory::deref()`. Part of the fix for servo/servo#7422.
pcwalton
referenced
this pull request
in pcwalton/servo
Sep 30, 2015
incorporate the fix for zero-sized shmem on Mac. Depends on servo/rust-azure#201 and pcwalton/ipc-channel#10. Closes servo#7422.
|
r+ |
pcwalton
added a commit
that referenced
this pull request
Sep 30, 2015
Guard against null pointers (which can exist if the size is zero) in
pcwalton
referenced
this pull request
in pcwalton/servo
Oct 1, 2015
incorporate the fix for zero-sized shmem on Mac. Depends on servo/rust-azure#201 and pcwalton/ipc-channel#10. Closes servo#7422.
bors-servo
referenced
this pull request
in servo/servo
Oct 1, 2015
Handle zero-sized source surfaces properly, and upgrade `ipc-channel` to incorporate the fix for zero-sized shmem on Mac. Depends on servo/rust-azure#201 and pcwalton/ipc-channel#10. Closes #7422. r? @mbrubeck (don't r+ until the upstream dependencies have landed) cc @jdm <!-- Reviewable:start --> [<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/7802) <!-- Reviewable:end -->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
pcwalton commentedSep 30, 2015
MachSharedMemory::clone()andMachSharedMemory::deref().Part of the fix for servo/servo#7422.