Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upCleanup: Derive `Debug` on `OsIpcSender` instead of manual `impl` #109
+1
−8
Conversation
The `Debug` implementation for `mpsc` has been upstream for quite a long time now -- so we can just derive one for `OsIpcSender` now. While the internal details the derived implementation will print may not be terribly useful, they shouldn't really hurt either; and this removes some lines of boilerplate code, so I consider it a win.
|
@bors-servo: r+ |
|
|
bors-servo
added a commit
that referenced
this pull request
Oct 5, 2016
Cleanup: Derive `Debug` on `OsIpcSender` instead of manual `impl` The `Debug` implementation for `mpsc` has been upstream for quite a long time now -- so we can just derive one for `OsIpcSender` now. While the internal details the derived implementation will print may not be terribly useful, they shouldn't really hurt either; and this removes some lines of boilerplate code, so I consider it a win.
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
antrik commentedOct 5, 2016
The
Debugimplementation formpschas been upstream for quite a longtime now -- so we can just derive one for
OsIpcSendernow.While the internal details the derived implementation will print may not
be terribly useful, they shouldn't really hurt either; and this removes
some lines of boilerplate code, so I consider it a win.