Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make RouterHandler an FnMut rather than an Fn. #12

Merged
merged 1 commit into from Jan 13, 2016

Conversation

@eefriedman
Copy link
Contributor

eefriedman commented Oct 12, 2015

This codifies the constraint that handlers can't be called recursively.

This codifies the constraint that handlers can't be called recursively.
@Ms2ger
Copy link
Contributor

Ms2ger commented Jan 13, 2016

@pcwalton
Copy link
Collaborator

pcwalton commented Jan 13, 2016

@bors-servo
Copy link
Contributor

bors-servo commented Jan 13, 2016

📌 Commit 9b71253 has been approved by pcwalton

@bors-servo
Copy link
Contributor

bors-servo commented Jan 13, 2016

Testing commit 9b71253 with merge dfd8513...

bors-servo added a commit that referenced this pull request Jan 13, 2016
Make RouterHandler an FnMut rather than an Fn.

This codifies the constraint that handlers can't be called recursively.
@bors-servo
Copy link
Contributor

bors-servo commented Jan 13, 2016

☀️ Test successful - travis

@bors-servo bors-servo merged commit 9b71253 into servo:master Jan 13, 2016
1 check passed
1 check passed
homu Test successful
Details
antrik added a commit to antrik/servo that referenced this pull request Jan 13, 2016
This pulls in servo/ipc-channel#25 and
servo/ipc-channel#12 servo#27, thus fixing fallout
from the multiprocess split, and making Servo work on my system again.

(It also pulls in servo/ipc-channel#12 -- I
guess that's fine?)
antrik added a commit to antrik/servo that referenced this pull request Jan 13, 2016
This pulls in servo/ipc-channel#25 and
servo/ipc-channel#27, thus fixing fallout from
the multiprocess split, and making Servo work on my system again.

(It also pulls in servo/ipc-channel#12 -- I
guess that's fine?)
bors-servo added a commit to servo/servo that referenced this pull request Jan 14, 2016
cargo-update ipc-channel to get important fixes

This pulls in servo/ipc-channel#25 and
servo/ipc-channel#27, thus fixing fallout from
the multiprocess split, and making Servo work on my system again.

(It also pulls in servo/ipc-channel#12 -- I
guess that's fine?)

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/9299)
<!-- Reviewable:end -->
bors-servo added a commit to servo/servo that referenced this pull request Jan 14, 2016
cargo-update ipc-channel to get important fixes

This pulls in servo/ipc-channel#25 and
servo/ipc-channel#27, thus fixing fallout from
the multiprocess split, and making Servo work on my system again.

(It also pulls in servo/ipc-channel#12 -- I
guess that's fine?)

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/9299)
<!-- Reviewable:end -->
gecko-dev-updater pushed a commit to marco-c/gecko-dev-comments-removed that referenced this pull request Oct 1, 2019
…(from antrik:update-ipc_channel); r=pcwalton

This pulls in servo/ipc-channel#25 and
servo/ipc-channel#27, thus fixing fallout from
the multiprocess split, and making Servo work on my system again.

(It also pulls in servo/ipc-channel#12 -- I
guess that's fine?)

Source-Repo: https://github.com/servo/servo
Source-Revision: 42372dbdf112c1c2967c4487401b28e7305c2993

UltraBlame original commit: d16cecf007bc7760538afc4ec593b1d6580648f2
gecko-dev-updater pushed a commit to marco-c/gecko-dev-wordified-and-comments-removed that referenced this pull request Oct 1, 2019
…(from antrik:update-ipc_channel); r=pcwalton

This pulls in servo/ipc-channel#25 and
servo/ipc-channel#27, thus fixing fallout from
the multiprocess split, and making Servo work on my system again.

(It also pulls in servo/ipc-channel#12 -- I
guess that's fine?)

Source-Repo: https://github.com/servo/servo
Source-Revision: 42372dbdf112c1c2967c4487401b28e7305c2993

UltraBlame original commit: d16cecf007bc7760538afc4ec593b1d6580648f2
gecko-dev-updater pushed a commit to marco-c/gecko-dev-wordified that referenced this pull request Oct 1, 2019
…(from antrik:update-ipc_channel); r=pcwalton

This pulls in servo/ipc-channel#25 and
servo/ipc-channel#27, thus fixing fallout from
the multiprocess split, and making Servo work on my system again.

(It also pulls in servo/ipc-channel#12 -- I
guess that's fine?)

Source-Repo: https://github.com/servo/servo
Source-Revision: 42372dbdf112c1c2967c4487401b28e7305c2993

UltraBlame original commit: d16cecf007bc7760538afc4ec593b1d6580648f2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.