Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upplatform/test: More test cases for receiver sets etc. #124
Conversation
|
This is mostly to establish a baseline for #123 |
|
Oh, now that's an interesting catch... Though not exactly what I was after ;-) |
antrik
force-pushed the
antrik:tests-receiver_set-etc
branch
2 times, most recently
from
9f5e8b0
to
b472513
antrik
force-pushed the
antrik:tests-receiver_set-etc
branch
2 times, most recently
from
163efcf
to
8390a33
|
I disabled the failing test on MacOS, since it can be argued that it doesn't expose a user-visible bug... Though the failure is still suspicious. |
This adds a bunch of new test cases improving coverage for `OsIpcReceiverSet`; along with a pair of tests for sending empty messages in general, which wasn't covered before at all.
|
Sounds good to me. Sorry this took so long to get reviewed @antrik, feel free to ping me if it happens again. I don't feel I have the time to do all the reviews I should in ipc-channel, but I'll try to find/bug an appropriate reviewer when possible. Thanks again! @bors-servo r+ |
|
|
platform/test: More test cases for receiver sets etc. This adds a bunch of new test cases improving coverage for `OsIpcReceiverSet`; along with a pair of tests for sending empty messages in general, which wasn't covered before at all.
|
|
|
@emilio thanks :-) I wish this repository had highfive, or some other measures to make sure PRs are taken care of... I hate having to prod people all the time; and I find the difficulty of landing things in |
What is needed to get high five enabled for this repo? What you describe is a situation we absolutely shouldn't be in. |
|
https://github.com/servo/highfive/#enabling-a-repo has steps to enable, although I don't have admin rights for this repo. |
metajack
commented
Dec 29, 2016
|
Highfive webhook has now been added to this repo. |
antrik commentedNov 14, 2016
This adds a bunch of new test cases improving coverage for
OsIpcReceiverSet; along with a pair of tests for sending emptymessages in general, which wasn't covered before at all.