Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upplatform/unix: Use `reserve_exact()` in `recv()` #130
Merged
Conversation
Since we know exactly at this point how large the message will be, there is no point in allowing the allocator to reserve more. While this doesn't actually show any measurable difference here, it still seems useful to express the constraint explicitly in the code -- to account for possible differences in allocators, for example; and possibly for clarity?
|
To be honest, this is mostly to stop wasting time pondering whether it's worthwhile submitting a PR for that or not ;-) |
|
Seems harmless :) |
|
|
bors-servo
added a commit
that referenced
this pull request
Jan 1, 2017
platform/unix: Use `reserve_exact()` in `recv()` Since we know exactly at this point how large the message will be, there is no point in allowing the allocator to reserve more. While this doesn't actually show any measurable difference here, it still seems useful to express the constraint explicitly in the code -- to account for possible differences in allocators, for example; and possibly for clarity?
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
antrik commentedJan 1, 2017
Since we know exactly at this point how large the message will be, there
is no point in allowing the allocator to reserve more.
While this doesn't actually show any measurable difference here, it
still seems useful to express the constraint explicitly in the code --
to account for possible differences in allocators, for example; and
possibly for clarity?