Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upRemove the assertions during panics #14
Merged
Conversation
|
BTW, I confirmed that Linux WPT & ref tests still pass with these changes. |
pcwalton
added a commit
that referenced
this pull request
Nov 30, 2015
Remove the assertions during panics
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
larsbergstrom commentedNov 20, 2015
r? @pcwalton
We have a bunch of intermittent failures in Servo and the problem is that if one thread (say script) panics, then as all of the threads with ipc-channel usage are torn down, their
dropmethods attempt to reclaim native resources that are not in a sensible state. These chain panics flood the output with ipc-channel failures and often hide the original failure.Only asserting if we are not panicking was OK'd by @alexcrichton.
I also got rid of a few
>=for==, sincecloseis only supposed to return0for success, as far as I could tell.