Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upCleanup dead code warnings #141
Merged
+4
−6
Conversation
- Add conditional compilation to incrementor - Remove unused type definitions in test code
dlrobertson
force-pushed the
dlrobertson:fix_compile_warnings
branch
from
e1b4820
to
bc61cef
| @@ -7,6 +7,7 @@ | |||
| // option. This file may not be copied, modified, or distributed | |||
| // except according to those terms. | |||
|
|
|||
| #[cfg(any(feature = "force-inprocess", not(target_os = "macos")))] | |||
This comment has been minimized.
This comment has been minimized.
antrik
Feb 11, 2017
Contributor
Gah, my bad: I explicitly removed the conditional in 09e22f6 , as I didn't realise unused modules produce a warning :-(
This comment has been minimized.
This comment has been minimized.
|
@bors-servo r+ |
|
|
bors-servo
added a commit
that referenced
this pull request
Feb 11, 2017
Cleanup dead code warnings - Add conditional compilation to `incrementor` - Remove unused type definitions in test code
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
dlrobertson commentedFeb 11, 2017
incrementor