Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upUse slab for unix OsIpcReceiverSet's tokens #147
Closed
Conversation
Use slab as the container for OsIpcReceiverSet's tokens and fds.
This was referenced Feb 14, 2017
| Ok(last_index) | ||
| if self.pollfds.has_available() { | ||
| let len = self.pollfds.len(); | ||
| self.pollfds.reserve_exact(len << 1); |
This comment has been minimized.
This comment has been minimized.
dlrobertson
Feb 14, 2017
Author
Collaborator
Not a huge fan of this. Any ideas on how to improve this?
|
It appears that servo/servo#15537 is still failing, which means my theory that it was a reused file descriptor is wrong. |
|
Indeed, this is not the problem at all -- see my (late) follow-up on #133 |
|
Not the actual cause of the problem. Keep |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
dlrobertson commentedFeb 14, 2017
Use slab as the container for OsIpcReceiverSet's tokens and fds.
Resolves:
Related to: