Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update mio. #158

Closed
wants to merge 2 commits into from
Closed

Update mio. #158

wants to merge 2 commits into from

Conversation

@jdm
Copy link
Member

jdm commented Mar 27, 2017

No description provided.

@jdm
Copy link
Member Author

jdm commented Mar 27, 2017

tokio-rs/mio@43a69f2, tokio-rs/mio@32f34cd, tokio-rs/mio@607fb54, tokio-rs/mio@c8312b7, and tokio-rs/mio@ef182ba look like commits that could have an impact on our Linux implementation. I want to see if these improve servo/servo#16154 at all.

@antrik
Copy link
Contributor

antrik commented Mar 27, 2017

@jdm I'm a bit confused: why do you need to update the version requirement in ipc-channel for that?

(BTW, I personally prefer doing the version bump in the same commit that introduces the change prompting the bump...)

@antrik
Copy link
Contributor

antrik commented Mar 27, 2017

On an unrelated note, what's up with highfive? That's the second time it failed to assign a reviewer...

@jdm
Copy link
Member Author

jdm commented Mar 27, 2017

I've always assumed that sometimes highfive runs afoul of github's API request limit.

@jdm
Copy link
Member Author

jdm commented Mar 27, 2017

Also this PR is not necessary to try out changes to mio in Servo. I thought it was.

@jdm jdm closed this Mar 27, 2017
@jdm jdm deleted the updatemio branch Mar 27, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.