tests: server_accept_first(): Drop bogus exclusion
#173
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I should have removed this conditional entirely (rather than just the Windows part) in 7881984 . The issue was never really Windows-specific in the first place: it just didn't become apparent until we could test the `inprocess` back-end on other platforms after 3e9aee8 . (Also, this should have used the "ignore" attribute, rather than conditional compilation: there was never any reason why the test couldn't be run on Windows, or on the `inprocess` back-end in general -- it uncovered an actual bug in the `inprocess` back-end implementation...)
Member
|
@bors-servo r+ |
Contributor
|
📌 Commit 1666c70 has been approved by |
bors-servo
pushed a commit
that referenced
this pull request
Oct 8, 2017
tests: `server_accept_first()`: Drop bogus exclusion I should have removed this conditional entirely (rather than just the Windows part) in 7881984 . The issue was never really Windows-specific in the first place: it just didn't become apparent until we could test the `inprocess` back-end on other platforms after 3e9aee8 . (Also, this should have used the "ignore" attribute, rather than conditional compilation: there was never any reason why the test couldn't be run on Windows, or on the `inprocess` back-end in general -- it uncovered an actual bug in the `inprocess` back-end implementation...)
Contributor
Contributor
|
☀️ Test successful - status-appveyor, status-travis |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I should have removed this conditional entirely (rather than just the
Windows part) in 7881984 . The issue
was never really Windows-specific in the first place: it just didn't
become apparent until we could test the
inprocessback-end on otherplatforms after 3e9aee8 .
(Also, this should have used the "ignore" attribute, rather than
conditional compilation: there was never any reason why the test
couldn't be run on Windows, or on the
inprocessback-end in general --it uncovered an actual bug in the
inprocessback-endimplementation...)