Skip to content

/ ipc-channel

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to bincode 0.9 #175

Merged
merged 2 commits into from Oct 12, 2017
Merged

Update to bincode 0.9 #175

merged 2 commits into from Oct 12, 2017

Conversation

@jrmuizel
Copy link
Contributor

jrmuizel commented Oct 12, 2017

bincode 0.9 comes with a reasonably big performance fix for
deserialization. WebRender has already switched.
@jdm
Copy link
Member

jdm commented Oct 12, 2017

@bors-servo: r+
@bors-servo
Copy link
Contributor

bors-servo commented Oct 12, 2017

📌 Commit 8cb8a5f has been approved by jdm
@highfive highfive assigned jdm and unassigned emilio Oct 12, 2017
@bors-servo
Copy link
Contributor

bors-servo commented Oct 12, 2017

⌛ Testing commit 8cb8a5f with merge f2396e5...
bors-servo added a commit that referenced this pull request Oct 12, 2017
@bors-servo
Auto merge of #175 - jrmuizel:bincode-update, r=jdm
Loading status checks…
f2396e5 
Update to bincode 0.9

bincode 0.9 comes with a reasonably big performance fix for
deserialization. WebRender has already switched.
@jrmuizel
Copy link
Contributor Author

jrmuizel commented Oct 12, 2017

@jdm can you do a release too?
@jdm
Copy link
Member

jdm commented Oct 12, 2017

@bors-servo: r-
@jdm
Copy link
Member

jdm commented Oct 12, 2017

Please update the crate version, in that case.
jrmuizel added 2 commits Oct 12, 2017
@jrmuizel
Update to bincode 0.9
b4a0687 
bincode 0.9 comes with a reasonably big performance fix for
deserialization. WebRender has already switched.
@jrmuizel
Bump version to 0.9.0
Loading status checks…
909fbc0
@jrmuizel jrmuizel force-pushed the jrmuizel:bincode-update branch from 8cb8a5f to 909fbc0 Oct 12, 2017
@jrmuizel
Copy link
Contributor Author

jrmuizel commented Oct 12, 2017

Done
@jdm
Copy link
Member

jdm commented Oct 12, 2017

@bors-servo: r+
@bors-servo
Copy link
Contributor

bors-servo commented Oct 12, 2017

📌 Commit 909fbc0 has been approved by jdm
@bors-servo
Copy link
Contributor

bors-servo commented Oct 12, 2017

⌛ Testing commit 909fbc0 with merge d22d044...
bors-servo added a commit that referenced this pull request Oct 12, 2017
@bors-servo
Auto merge of #175 - jrmuizel:bincode-update, r=jdm
Loading status checks…
d22d044 
Update to bincode 0.9

bincode 0.9 comes with a reasonably big performance fix for
deserialization. WebRender has already switched.
@staktrace staktrace mentioned this pull request Oct 12, 2017
Closed
@bors-servo
Copy link
Contributor

bors-servo commented Oct 12, 2017

☀️ Test successful - status-appveyor, status-travis
Approved by: jdm
Pushing d22d044 to master...
@bors-servo bors-servo merged commit 909fbc0 into servo:master Oct 12, 2017
3 checks passed
3 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
@antrik
Copy link
Contributor

antrik commented Oct 13, 2017

Was there actually some change that could break downstream users: either in the API (I think error codes are the only thing from bincode we expose downstream?); or in the binary format? If so, that should be mentioned in the commit message; and if not, AIUI the convention would be only to bump to 0.8.1, thus avoiding unnecessary churn in downstream users?...
@jrmuizel
Copy link
Contributor Author

jrmuizel commented Oct 13, 2017

@antrik rust-semverver complained about a bunch of error related things changing. I'll include more information in the commit message next time.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@jdm jdm

Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

6 participants
@jrmuizel @jdm @bors-servo @antrik @emilio @highfive
You can’t perform that action at this time.